From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id A3E111580FD for ; Tue, 24 Dec 2024 14:31:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EB43BE081B; Tue, 24 Dec 2024 14:31:19 +0000 (UTC) Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AD1CAE07C9 for ; Tue, 24 Dec 2024 14:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1735050676; x=1735309876; bh=kjd0poUm9+rz3clW7zUmX8yGnNEaat14JuaJICpr1qs=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=b8w2zSwTOroeCYbl0g6bN3hLkd87albDt+CLEgncNxeWmeqbjFoPDhA8qguR//ibC EM0X9sPHpqbg8kuAavaQnxOo0Sy/VNqHlIX4GMdjK7KaO4aQwb/6JwZmhiSnPoQ9Kj aJcjDnNWOBIuwUZqhloBycInaggQ+oLbR6+QWm+S83Ni0rpWY6s6IIUis4Thl2wJsh eRDg2QZNqIL55d15+zwSWsrZgV44yUYT7J77/VbSYEyPQjX13qXaFWZa5Krzi5OZ0j W5PfPPmMAdbm4XGAni8HHifQMLauEzi1ggrNFYlzStmu/wkPl2n2PDXhN4iIcDR99v OpqaPhN+lF7iw== Date: Tue, 24 Dec 2024 14:31:12 +0000 To: gentoo-dev@lists.gentoo.org From: Filip Kobierski Subject: Re: [gentoo-dev] TIDAL ebuild Message-ID: In-Reply-To: References: Feedback-ID: 115236665:user:proton X-Pm-Message-ID: 6f87ec748a93926f922c537d5819e01ad0cab123 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha512; boundary="------8d49ee3a71fdcd3d6000d96bbbe4620ac3ce1191e1e8b81fb2c5ac33d79b68b0"; charset=utf-8 X-Archives-Salt: 2b503a04-8807-4101-b5dc-ee55b9d282da X-Archives-Hash: a3e6bb9336f74e96cbda1c6a28869a20 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------8d49ee3a71fdcd3d6000d96bbbe4620ac3ce1191e1e8b81fb2c5ac33d79b68b0 Content-Type: multipart/mixed;boundary=---------------------2603429fae9dfe6899461afd465cd565 -----------------------2603429fae9dfe6899461afd465cd565 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain;charset=utf-8 Errata: I have just looked up the upstream and I think the name is fine. However I would mention somewhere that it's a third party app. (AFAIR discord also is an electron app and 3rd party client note that they are not official) = On Tuesday, December 24th, 2024 at 15:26, Filip Kobierski wr= ote: > Hi Daniel, > = > I am no ebuild-master myself but I think I have some feedback; > - since it's a -bin package make sure to have -* in KEYWORDS > - use desktop.eclass[1]: > - domenu for the desktop file > - doicon for the icon > - also I would use dobin for installing binaries > - I would use ${PN} where possible (besides SRC_URI & HOMEPAGE > = > On the name though, is the -bin really nescessary if there is no > source option? On one hand we have net-im/discord but on the other > there's net-im/discord-canary-bin. > Another thing is the -hifi part. For me it implies that before > there was some non-hifi version. If that's the case than that is > fine to me. > I however would name the package tidal-desktop or just tidal. > = > = > I hope that this helps > Filip Kobierski > = > [1]: https://devmanual.gentoo.org/eclass-reference/desktop.eclass/ > = > On Tuesday, December 24th, 2024 at 15:11, Daniel Buschke damage@devloop.= de wrote: > = > > Hi all, > > TIDAL is a music streaming service. As I missed a TIDAL desktop app on > > gentoo I created an ebuild based on > > https://github.com/Mastermindzh/tidal-hifi. > > = > > It's a node js application which drove me a bit crazy. I was today yea= rs > > old when I realized that the gentoo emerge sandbox is cutting network > > access :) > > But the node js application, as every node js app, heavily relies on > > dependencies, so I decided to go with the binary version. > > = > > Anyway, as I am not very firm with ebuilds it would be nice if someone > > could do a review before I try to commit this ebuild to the official > > portage via bugs.gentoo.org. Anyone? Thanks in advance. > > = > > https://source.devloop.de/damage/gentoo/src/branch/main/media-sound/ti= dal-hifi-bin > > = > > Stay healthy, everyone out there. > > = > > regards > > Daniel -----------------------2603429fae9dfe6899461afd465cd565-- --------8d49ee3a71fdcd3d6000d96bbbe4620ac3ce1191e1e8b81fb2c5ac33d79b68b0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wnUEARYKACcFgmdqxZgJkAUVAewu4JXrFiEEDDuAKD1tNsX0bzf/BRUB7C7g lesAAMGPAQDs8yPmwDv1GHBtw7SYxdxENxdgwIGf/ys7kWUyusjPnAEA3qkH SQV3AaqrifAlSOYAsbChtH3KnBpBTg9pxraxcwc= =sIqC -----END PGP SIGNATURE----- --------8d49ee3a71fdcd3d6000d96bbbe4620ac3ce1191e1e8b81fb2c5ac33d79b68b0--