From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 84AD01581F3 for ; Fri, 29 Nov 2024 09:11:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 69B72E082F; Fri, 29 Nov 2024 09:11:12 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BD177E07EF for ; Fri, 29 Nov 2024 09:11:11 +0000 (UTC) Date: Fri, 29 Nov 2024 04:11:08 -0500 From: Ionen Wolkens To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] Add 'host' variable to GIT_CRATES to support other host like self-host gitlab or gitea Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20241127154707.39679-1-mytdragon@protonmail.com> <642e2d85-7d75-4b0f-8a16-037a4f692e5c@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jOWAJEJQPr0VfSbw" Content-Disposition: inline In-Reply-To: X-Archives-Salt: 6816983a-6d68-49de-807b-11b31c1c3849 X-Archives-Hash: 4b48b55eccb4961a69c04c67c6415a4f --jOWAJEJQPr0VfSbw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 29, 2024 at 01:42:40AM +0000, MYT wrote: > Hi Paul, >=20 > thanks for the reply. To be honest I'm a bit confused about your suggesti= on as I don't think I declared any new associative array. The patch only ad= d new value in the string with delimeter. So I'm not sure what you expect m= e to change there :) Probably(?) seen the new documentation bit with declare -A GIT_CRATES, however it matches the other example and that's fine. Also, -g should not really matter for that specific associative array (should make no real difference if it's local or global) and we haven't been using -g for that array across the tree in ebuilds. If there is a problem, then it would be beyond the scope of the changes you're proposing and it should be handled elsewhere (it'd be a tree-wide issue). tl;dr nothing for you to change there >=20 > MYT >=20 >=20 > On Wednesday, 27 November 2024 at 16:14, Paul Zander wrote: >=20 > >=20 > >=20 > > Hi, > >=20 > > associative arrays declared in functions are implicitly local in bash. > >=20 > > That means any associative array declared in global ebuild scope needs > > to be declare global explicitly, as it's not guaranteed not to be > > sourced within a function by a PM ( e.g. paludis does this ). > >=20 > > https://lists.gnu.org/archive/html/bug-bash/2011-08/msg00274.html > > https://github.com/pkgcore/pkgcheck/issues/628 > >=20 > > Paul >=20 --=20 ionen --jOWAJEJQPr0VfSbw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmdJhSsACgkQskQGsLCs QzTNXAgApfhhpeGR+Gs4778LjzoK4nHyFJYjjNoLERh/Ze4c1q1BhLJnYdB0eDMs z7JKHecy5Jn6GaSco1VPx4WAr8AlOpj7pj2msA+yrSmSGnKMfAxwjTOumpdy8pvI UkNO8vKX4OmGter2A3/nqPkkz3MFw85YOHA1xvaAIYGCi19WGfzRENB2xbq8jaDJ oEX3PfNqmhUEiJfl4TvLMJIV2pKrUo8dC2DXgWwznhPCHh/L85sLLDcankGRKvbt O43FRbIM4LgY2mMWyOp1OTBUS10BLMV9PCfJSSIMoxijYhehlHaOar9GXBRQk5Rk IPTnx08KBoxGtbkL0q+YzgQw51zo8Q== =4O3h -----END PGP SIGNATURE----- --jOWAJEJQPr0VfSbw--