From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BFD6F15813A for ; Sun, 12 Jan 2025 21:21:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 97249E0815; Sun, 12 Jan 2025 21:21:06 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 12098E07F6 for ; Sun, 12 Jan 2025 21:21:05 +0000 (UTC) Date: Sun, 12 Jan 2025 16:20:59 -0500 From: Ionen Wolkens To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] cargo.eclass: Emit a warning if the package uses 300+ crates Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20250112125639.15047-1-mgorny@gentoo.org> <2498321.jE0xQCEvom@fcf> <1067019a-fe12-4793-8ff1-a1e21dbcb3ae@asokolov.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iLY9UBKfj2HFgQtu" Content-Disposition: inline In-Reply-To: <1067019a-fe12-4793-8ff1-a1e21dbcb3ae@asokolov.org> X-Archives-Salt: 9b0ad820-e470-454b-8c61-5fc8ac9ea9b0 X-Archives-Hash: 0ed9561c404714ea89345bca0bf03db3 --iLY9UBKfj2HFgQtu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 12, 2025 at 02:30:10PM +0000, Alexey Sokolov wrote: > 12.01.2025 13:15, Agostino Sarubbo =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 > > On domenica 12 gennaio 2025 13:56:39 CET Micha=C5=82 G=C3=B3rny wrote: > > > >> + if [[ ${#crates[@]} -ge 300 ]]; then > > > >> + eqawarn "This package uses a very large number of > > > >> CRATES. Please provide" + eqawarn "a crate tarball > > > >> instead and fetch it via SRC_URI. You can use" + > > > >> eqawarn "'pycargoebuild --crate-tarball' to create one." + fi > > > > I would like to suggest to use "QA Notice: " prefix if you want to have= them reported. > > > > Agostino >=20 > Side question: maybe eqawarn should add such prefix automatically? In the context of automatically filing bugs, sometimes we also want to warn for low priority things (e.g. either just something to be aware of or something to ideally fix on bump when happen to see the warning) without filing a hundred bugs. So question is more whether we want this to happen here or not and put pressure on maintainers (incl. proxied) to fix it asap. =46rom a technical standpoint, eqawarn would need to know when it's the "header" of a notice (like optfeature_header) given we often have several eqawarn in a row and "QA Notice:" for each line would be weird. This means needing to modify all usage of it anyway which doesn't bring much vs just inlining it unless we wanted to do something more special with this. --=20 ionen --iLY9UBKfj2HFgQtu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmeEMjsACgkQskQGsLCs QzRRIAgAvkG7xPIcgYgjXxpz1MGrpurhqxafdAdBMOaNN+34Cg3VhobhlssRYkW+ ZwP+6CWsHM1pmlJVp5WUai+MfSZjAp6a4ZTi98rqzdrMfMZxhR5mRfqLWLAblz4G gjQ6AYv/Tq/X/AIZVCqav7xqVkjS5dLA0y1OlC5ovHBUv0mZ2U2/Lg3npCc4v0m3 Bno6/Le8JwDfjlOqXtGmfhQqjyFHEyRZgNgrE6rm9ZPwpknWLqoln6zHmY/vUilD VNbRLLkbwc8zTE7xNqIs2rJK2t607mu8lc8z5VJu8DeBaR4m3Iku3V9S12ko74SL xpBNuw0CCHSU6U0gUBASLDDUTLtL7A== =CxJQ -----END PGP SIGNATURE----- --iLY9UBKfj2HFgQtu--