From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D9548158B20 for ; Wed, 05 Feb 2025 19:07:36 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id C4F8034307A for ; Wed, 05 Feb 2025 19:07:36 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 2363B110479; Wed, 05 Feb 2025 19:06:43 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 57B491103CB for ; Wed, 05 Feb 2025 19:06:42 +0000 (UTC) Received: from eversor (unknown [24.157.215.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ionen) by smtp.gentoo.org (Postfix) with ESMTPSA id AB2DC335D0F; Wed, 05 Feb 2025 19:06:41 +0000 (UTC) Date: Wed, 5 Feb 2025 14:06:39 -0500 From: Ionen Wolkens To: gentoo-dev@lists.gentoo.org Cc: toolchain@gentoo.org, Mike Gilbert Subject: Re: [gentoo-dev] [PATCH] toolchain-funcs.eclass: avoid using tc-getCPP in compiler checks Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org, toolchain@gentoo.org, Mike Gilbert References: <20250205181010.1968506-1-floppym@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ik7OwChIcw4y/mfu" Content-Disposition: inline In-Reply-To: <20250205181010.1968506-1-floppym@gentoo.org> X-Archives-Salt: 4bda271f-407d-4aa4-b2d2-d5d177a39bda X-Archives-Hash: 15ad037ce7ddb9e330fca33b7ea2e550 --Ik7OwChIcw4y/mfu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 05, 2025 at 01:10:10PM -0500, Mike Gilbert wrote: > We usually want to invoke cc -E rather than cpp directly. We should not > rely on the quirk of tc-getCPP defaulting to "cc -E" when CPP is unset. I think it's a good change, but just to note it could break things that relied on CPP being what's used. Aka these don't have a proper way to say "test this compiler" and, given it uses CPP, it's what I ended up setting: CPP=3D"${KERNEL_CC} -E" tc-is-clang ... That's from nvidia-drivers ebuilds, which I'll fix real soon so no need to worry about these. But I don't know what else may have done this, not that I think it's going to be common. I did something similar in linux-mod-r1.eclass but I took more precaution there so it's not affected: # for toolchain-funcs, uses CPP > CC but set both not to make assumptio= ns local CC=3D${KERNEL_CC} CPP=3D"${KERNEL_CC} -E" LD=3D${KERNEL_LD} I could cleanup the CPP bit if this is merged though. That it doesn't use CC was confusing if anything thus needing a comment to explain why it's being set. Hopefully haven't forgot anything else I did, think wine & mingw things are fine. --=20 ionen --Ik7OwChIcw4y/mfu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmejtqsACgkQskQGsLCs QzSNLQgAm8Y24ivfWsuQttbtBi18bT8DyMZ+kfFDzs98pnTNH5Y/7sIEHkh8L8os MOa1sTPb1cLs92JfY+cW7EIyPvVkIDNepuqhPSBCKJq7RmzGIn2P5MC0Bz7FZZvY UW5YH6qi9BCYQXbBdp+o1VVrhg1Ls+SnWG7muaHJx5BY+70UKZgsbq4ul0ux0d14 VjoHe4XaiL2aACUeLUTEy49ueVtLSa1+8eMq3gfEHjq5g6/viMZD9mxCRjVLb9K0 90AVna3CExkrm6MjaDSt1N4sTuK056HSMHEjnl3mBJqtkzRev7DTVJ+oZtezz1Ts ys6jCc/RFI/fRRoNsIbJTXUOG+mgZA== =B1eT -----END PGP SIGNATURE----- --Ik7OwChIcw4y/mfu--