public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/2] acct-user.eclass: Support ACCT_USER_ID override
Date: Wed, 06 Jan 2021 20:11:49 +0100	[thread overview]
Message-ID: <a345f066f1f67686bd82572326db8bb62c4820af.camel@gentoo.org> (raw)
In-Reply-To: <u7doq19ju@gentoo.org>

On Wed, 2021-01-06 at 14:25 +0100, Ulrich Mueller wrote:
> > > > > > On Tue, 05 Jan 2021, Michał Górny wrote:
> 
> > +	# check for the override
> > +	local override_name=${ACCT_USER_NAME^^}
> > +	local override_var=ACCT_USER_${override_name//-/_}_ID
> 
> I wonder about this line. Both hyphen and underscore are valid
> characters in user names.
> 
> So, ACCT_USER_FOO_BAR_ID would override the id for both foo_bar and
> foo-bar users.

I don't think this is the problem we need to be worrying about.  I mean,
if someone actually created user identifiers that differ only be non-
alnum characters, I think that'd the problem to tackle.

-- 
Best regards,
Michał Górny




  parent reply	other threads:[~2021-01-06 19:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 18:39 [gentoo-dev] [PATCH 1/2] acct-user.eclass: Support ACCT_USER_ID override Michał Górny
2021-01-05 18:39 ` [gentoo-dev] [PATCH 2/2] acct-group.eclass: Support ACCT_GROUP_ID override Michał Górny
2021-01-06 13:25 ` [gentoo-dev] [PATCH 1/2] acct-user.eclass: Support ACCT_USER_ID override Ulrich Mueller
2021-01-06 14:02   ` Thomas Deutschmann
2021-01-06 19:05     ` Patrick McLean
2021-01-06 19:12       ` Alec Warner
2021-01-06 19:31         ` Thomas Deutschmann
2021-01-06 19:43       ` Thomas Deutschmann
2021-01-06 19:11   ` Michał Górny [this message]
2021-01-06 20:09     ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a345f066f1f67686bd82572326db8bb62c4820af.camel@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox