Re: [gentoo-dev] [PATCH 2/5] zig-build.eclass: new eclass

["Maciej Barć" <xgqt@gentoo.org>]

[-- Attachment #1.1.1: Type: text/plain, Size: 893 bytes --]

> +	if tc-is-cross-compiler; then
> +		ZBS_ARGS_BASE+=(
> +			# TODO add to upstream some way to add different search prefixes
> +			# for binaries, include paths and libraries, like existing --prefix-exe-dir etc.
> +			# Right now std.Build.findProgram will try to search here first, before PATH,
> +			# but std.Build.run and std.Build.runAllowFail use passed arguments as is and
> +			# uses std.process.Child under the hood, which itself can use PATH.
> +			#
> +			# Passing "--search-prefix" when not cross-compiling gives these 

Could we move this TODO comment above the function 
`zig-build_start_base_args`?
1. it will improve readability by giving a TODO block up-front,
2. putting this inside a 3-step indent is a bit too much.

-- 
Have a great day!

~ Maciej Barć

https://wiki.gentoo.org/wiki/User:Xgqt
9B0A 4C5D 02A3 B43C 9D6F D6B1 14D7 4A1F 43A6 AC3C


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 16315 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]