Re: [gentoo-dev] [PATCH v2 1/2] sec-keys.eclass: new eclass

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Thu, 2024-11-28 at 16:56 +0000, Sam James wrote:
> Eli Schwartz <eschwartz@gentoo.org> writes:
> 
> > On 11/28/24 8:10 AM, Michał Górny wrote:
> > > On Wed, 2024-11-27 at 23:32 -0500, Eli Schwartz wrote:
> > > 
> > > That looks like something you could do in src_compile() already.
> > 
> > 
> > Perhaps. But it felt like exporting keys is work that is conceptually
> > part of installing, in much the way that running a meson project's
> > `meson install` step does more than just copy files into ${D} -- it also
> > processes those files in order to do things like patch the rpath.
> > 
> > I guess I am not too attached to either approach.
> 
> I think I very loosely prefer doing it in src_compile as it's
> "compilation" of the resulting files and then src_install just moving
> the bundle, but I hardly feel strongly about it at all and feel it's
> personal preference. Not worth the electrons ;)

My point was mostly that you wouldn't have to start with GNUPGHOME
again.  Also, tests might be able to reuse the result then.  Also, tests
wouldn't be able to mess up src_install() (think of test-fail-continue
too).

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]