[gentoo-dev] [PATCH 1/2] eclass/dotnet-pkg-base: disable MSBUILDTERMINALLOGGER for new .NET 9.0 pkgs

[gentoo-dev] [PATCH 1/2] eclass/dotnet-pkg-base: disable MSBUILDTERMINALLOGGER for new .NET 9.0 pkgs

[xgqt]

From: Maciej Barć <xgqt@gentoo.org>

Disable the fancy terminal logger introduced in .NET 9.0.
If enabled, it messes up the Portage log file output.

Signed-off-by: Maciej Barć <xgqt@gentoo.org>
---
 eclass/dotnet-pkg-base.eclass | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/eclass/dotnet-pkg-base.eclass b/eclass/dotnet-pkg-base.eclass
index 8ec21c9a27..d9abff3859 100644
--- a/eclass/dotnet-pkg-base.eclass
+++ b/eclass/dotnet-pkg-base.eclass
@@ -104,6 +104,9 @@ export POWERSHELL_UPDATECHECK=0
 # Speeds up restore. Having this turned on is redundant with Portage manifests.
 # See also: https://github.com/NuGet/Home/issues/13062
 export DOTNET_NUGET_SIGNATURE_VERIFICATION=false
+# Disable the fancy terminal logger introduced in .NET 9.0.
+# It messes up the Portage log file output.
+export MSBUILDTERMINALLOGGER=off
 # Overwrite selected MSBuild properties ("-p:XYZ").
 export UseSharedCompilation=false
 
-- 
2.45.2

[gentoo-dev] [PATCH 2/2] eclass/nuget: add eclassdoc that describes how to generate the NUGETS list

[xgqt]

From: Maciej Barć <xgqt@gentoo.org>

Some users asked for it. Also add a link to the Gentoo Wiki with more
specific examples.

Signed-off-by: Maciej Barć <xgqt@gentoo.org>
---
 eclass/nuget.eclass | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/eclass/nuget.eclass b/eclass/nuget.eclass
index 4efbeb909f..3ad22fda2b 100644
--- a/eclass/nuget.eclass
+++ b/eclass/nuget.eclass
@@ -71,6 +71,24 @@ export NUGET_PACKAGES
 # @DESCRIPTION:
 # String containing all NuGet packages that need to be downloaded.
 #
+# To generate the "NUGETS" list use the "gdmt restore" tool from the
+# "dev-dotnet/gentoo-dotnet-maintainer-tools" package. To see all "gdmt restore"
+# options invoke it with the "--help" flag. The Gentoo Wiki page
+# Dotnet/Devguide (https://wiki.gentoo.org/wiki/Dotnet/Devguide) contains
+# examples and special cases to be beware of.
+#
+# Generally you will want to invoke "gdmt restore" form within a (clean) tagged
+# checkout of a given .NET-based project. The invocation will look something
+# like this: gdmt restore --sdk-ver SDK-VER --cache "$(pwd)/.cache" --project PROJECT
+# Where:
+#   * "SDK-VER" is a .NET version (6.0, 8.0), mind the full version, "8" is not allowed,
+#   * "PROJECT" is a given project file (.csproj or .fsproj) or a directory containing it.
+# So, for example:
+# gdmt restore --sdk-ver 8.0 --cache "$(pwd)/.cache" --project src/App/App.csproj
+#
+# When formatting the "NUGETS" list it is better to not indent it,
+# but it can be indented with single tab.
+#
 # Used by "_nuget_uris".
 #
 # Example:
-- 
2.45.2

Re: [gentoo-dev] [PATCH 2/2] eclass/nuget: add eclassdoc that describes how to generate the NUGETS list

[James Le Cuirot]

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

On Wed, 2024-11-20 at 22:50 +0100, xgqt@gentoo.org wrote:
> From: Maciej Barć <xgqt@gentoo.org>
> 
> Some users asked for it. Also add a link to the Gentoo Wiki with more
> specific examples.
> 
> Signed-off-by: Maciej Barć <xgqt@gentoo.org>
> ---
>  eclass/nuget.eclass | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/eclass/nuget.eclass b/eclass/nuget.eclass
> index 4efbeb909f..3ad22fda2b 100644
> --- a/eclass/nuget.eclass
> +++ b/eclass/nuget.eclass
> @@ -71,6 +71,24 @@ export NUGET_PACKAGES
>  # @DESCRIPTION:
>  # String containing all NuGet packages that need to be downloaded.
>  #
> +# To generate the "NUGETS" list use the "gdmt restore" tool from the
> +# "dev-dotnet/gentoo-dotnet-maintainer-tools" package. To see all "gdmt restore"
> +# options invoke it with the "--help" flag. The Gentoo Wiki page
> +# Dotnet/Devguide (https://wiki.gentoo.org/wiki/Dotnet/Devguide) contains
> +# examples and special cases to be beware of.
> +#
> +# Generally you will want to invoke "gdmt restore" form within a (clean) tagged
> +# checkout of a given .NET-based project. The invocation will look something
> +# like this: gdmt restore --sdk-ver SDK-VER --cache "$(pwd)/.cache" --project PROJECT
> +# Where:
> +#   * "SDK-VER" is a .NET version (6.0, 8.0), mind the full version, "8" is not allowed,
> +#   * "PROJECT" is a given project file (.csproj or .fsproj) or a directory containing it.
> +# So, for example:
> +# gdmt restore --sdk-ver 8.0 --cache "$(pwd)/.cache" --project src/App/App.csproj
> +#
> +# When formatting the "NUGETS" list it is better to not indent it,
> +# but it can be indented with single tab.
> +#
>  # Used by "_nuget_uris".
>  #
>  # Example:

Nice! I did this once, and then totally forgot how to do it the next time.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 858 bytes --]

Re: [gentoo-dev] [PATCH 2/2] eclass/nuget: add eclassdoc that describes how to generate the NUGETS list

[Matt Jolly]

Hi,

On 21/11/24 07:50, xgqt@gentoo.org wrote:
> +# When formatting the "NUGETS" list it is better to not indent it,
> +# but it can be indented with single tab.

This seems at-odds with the general style of ebuilds in ::gentoo.
Looking at CRATES as an example of a similar variable, this is
almost always indented, as is the content of any other multiline
string (e.g. SRC_URI). The now-deprecated EGO_SUM var was also
by-convention indented (though it was an array...).

Is there any existing policy that favours one of these over the
other?

LGTM otherwise; better documentation is always good!

Cheers,

Matt

Re: [gentoo-dev] [PATCH 2/2] eclass/nuget: add eclassdoc that describes how to generate the NUGETS list

[Maciej Barć]

[-- Attachment #1.1.1: Type: text/plain, Size: 1429 bytes --]

> Is there any existing policy that favours one of these over the
> other?

I don't think so, dev/user is free to decide on their own.

But IMO it is better to not use any space/tabs for NUGETS to reduce 
char. space taken by the list. We already force tabs in ebuilds to 
shrink number of characters.
Also, IMHO indentation for those huge chunks that are **defined 
globally** like CRATES and EGO_SUM makes them less readable.

.NET project pkgs use the """no-char""" style. In fact were using that 
since the conception and nobody complained.

W dniu 21.11.2024 o 01:09, Matt Jolly pisze:
> Hi,
> 
> On 21/11/24 07:50, xgqt@gentoo.org wrote:
>> +# When formatting the "NUGETS" list it is better to not indent it,
>> +# but it can be indented with single tab.
> 
> This seems at-odds with the general style of ebuilds in ::gentoo.
> Looking at CRATES as an example of a similar variable, this is
> almost always indented, as is the content of any other multiline
> string (e.g. SRC_URI). The now-deprecated EGO_SUM var was also
> by-convention indented (though it was an array...).
> 
> Is there any existing policy that favours one of these over the
> other?
> 
> LGTM otherwise; better documentation is always good!
> 
> Cheers,
> 
> Matt
> 
> 
> 

-- 
Have a great day!

~ Maciej Barć

https://wiki.gentoo.org/wiki/User:Xgqt
9B0A 4C5D 02A3 B43C 9D6F D6B1 14D7 4A1F 43A6 AC3C


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 16315 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]