From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id AFA6F158232 for ; Tue, 10 Dec 2024 08:26:47 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CB15FE0C78; Tue, 10 Dec 2024 08:26:43 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D7977E0C35 for ; Tue, 10 Dec 2024 08:26:42 +0000 (UTC) Message-ID: Date: Tue, 10 Dec 2024 03:26:38 -0500 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] [PATCH] profiles/default/linux: export cache variables for sed and friends To: gentoo-dev@lists.gentoo.org References: <4bfc3e7b67c2a1398c8efa9700b66fe9ac0f2736.1733352922.git.sam@gentoo.org> <87a5d4nl8h.fsf@gentoo.org> Content-Language: en-US From: Eli Schwartz Autocrypt: addr=eschwartz@gentoo.org; keydata= xjMEZmeRNBYJKwYBBAHaRw8BAQdAYNZ7pUDWhx1i2f3p6L2ZLu4FcY18UoeGC04Gq/khqwfN I0VsaSBTY2h3YXJ0eiA8ZXNjaHdhcnR6QGdlbnRvby5vcmc+wpYEExYKAD4WIQTvUdMIsc4j CIi+DYTqQj6ToWND8QUCZoRL+gIbAwUJBKKGAAULCQgHAwUVCgkICwUWAgMBAAIeBQIXgAAK CRDqQj6ToWND8aB5AP9r4kB691nNtNwKkdRiOdl7/k6WYzokvHvDamXxRJ0I+gEAjZqR5V8y mfR3fy2Z+r2Joeqdt3CIv5IwPs64spBvigLOOARmZ5E0EgorBgEEAZdVAQUBAQdATT46Z06b 1X9xjXFCYFxmq/Tj3tSEKZInDWTpoHQp4l8DAQgHwn4EGBYKACYWIQTvUdMIsc4jCIi+DYTq Qj6ToWND8QUCZmeRNAIbDAUJBKKGAAAKCRDqQj6ToWND8a2RAP40KPfbfoiZAJW5boFmFJ3G TUBDJRh9CWHyaPqq2PN+0wD/R07oLzfnJUN209mzi9TuTuHjeZybysyqXSw4MAxkMAY= In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------OBaJ1mxK1yMjgFAO4ktVjWXL" X-Archives-Salt: 8dc31427-d767-427c-a568-81c397a4925d X-Archives-Hash: 433562339af5f949fdfedb9660e76a77 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------OBaJ1mxK1yMjgFAO4ktVjWXL Content-Type: multipart/mixed; boundary="------------0xmf7TwqFA0sCQzfyIEZFVJm"; protected-headers="v1" From: Eli Schwartz To: gentoo-dev@lists.gentoo.org Message-ID: Subject: Re: [gentoo-dev] [PATCH] profiles/default/linux: export cache variables for sed and friends References: <4bfc3e7b67c2a1398c8efa9700b66fe9ac0f2736.1733352922.git.sam@gentoo.org> <87a5d4nl8h.fsf@gentoo.org> In-Reply-To: --------------0xmf7TwqFA0sCQzfyIEZFVJm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/10/24 3:02 AM, Ionen Wolkens wrote: > Albeit I don't understand what would be doing in there, setting the > full path for the current profile wouldn't accomplish anything for > binpkg-on-different-usr-type-profile. It surely would -- the point of setting it for the current profile is to make ./configure stop storing overly-specific build time paths, which means that the resulting binpkg is now well-formed and works on both profiles. It is a bug when e.g. `libgcrypt-config` stores contents like this: for i in $includes $cflags_final; do if echo "$tmp" | /usr/bin/grep -F -v -- "$i" >/dev/null; then But the suggested profile change would make this be: for i in $includes $cflags_final; do if echo "$tmp" | grep -F -v -- "$i" >/dev/null; then And Michael is suggesting we instead encode the "API filename": for i in $includes $cflags_final; do if echo "$tmp" | /bin/grep -F -v -- "$i" >/dev/null; then Since on both split and merged-usr systems, grep is always in /bin -- same as bash and sh > (on a related another note, do hope autoconf moves to being handled > like cmake/meson in the future so these things could just be in an > eclass -- we could do more complex things if needed too without > needing profile.bashrc) tbh, /usr/share/config.site exists for this. Despite previous history of being used for fragile caching of arbitrary configure checks that ended up dismantled and given up as too dangerous, it remains a perfectly suitable place for configuring impossible-to-change information such as policy-defined paths. > That aside, I personally feel that an option could instead be > to consider merged-usr binpkg on non-merged-usr as unsupported > and only support merged-usr for binary packages. Sure, we could declare tons of things as unsupported. We could declare split-usr as unsupported, in fact, which would feel a bit more honest than saying "split-usr is supported, we have profiles for it, just if you use it there are weird footguns and then your system breaks". It's not a hard fix. It's correcting something that should be the case regardless, even for merged-usr systems. It's quite silly for scripts to configure the absolute path to `grep`. > The issue still semi-exists for users migrating their systems, but > it's at least mitigated by 23.0 suggesting emerge -e @world and thus > updating every paths. I don't see how that's supposed to help, especially given that if you migrate your system then affected packages are defined as "affected" based on whether they are broken and fail to work, and that remains true during -e as well since packages depending on the broken package will fail to successfully -e. --=20 Eli Schwartz --------------0xmf7TwqFA0sCQzfyIEZFVJm-- --------------OBaJ1mxK1yMjgFAO4ktVjWXL Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTnFNnmK0TPZHnXm3qEp9ErcA0vVwUCZ1f7PgUDAAAAAAAKCRCEp9ErcA0vV+cS AP0ewBB2WzAT7tJ1Ja4d5hh9i4EuUHkp3N7aB2oSkn6zEQD/Q83mwNI7N6pZbOBOjB6fQ3BwMc/P 40aecCN6roXKnQQ= =3WY2 -----END PGP SIGNATURE----- --------------OBaJ1mxK1yMjgFAO4ktVjWXL--