Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: disable setuptools validation of pypi.org allowed strings

[Eli Schwartz <eschwartz@gentoo.org>]

[-- Attachment #1.1: Type: text/plain, Size: 861 bytes --]

On 11/12/24 1:37 PM, Michał Górny wrote:
>> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
>> index 7ab8dcae3265..9b9ba4b803ac 100644
>> --- a/eclass/distutils-r1.eclass
>> +++ b/eclass/distutils-r1.eclass
>> @@ -1360,6 +1360,17 @@ distutils_pep517_install() {
>>  					EOF
>>  				)
>>  			fi
>> +			if [[ ${BDEPEND} != *dev-python/trove-classifiers* ]]; then
> 
> It's not valid to access stacked variables like BDEPEND from ebuilds.


For what reason is it invalid? Is it about whether this will work
correctly or is there a policy reason banning it or... ?


Note that this happens inside of a phase function, not at global scope.
So the value of the variable is determined by the contents of the
environment file, not from the incremental value when sourcing the
eclass at global scope.


-- 
Eli Schwartz

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]