From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 928A5158042 for ; Tue, 12 Nov 2024 20:00:36 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 64CA1E080E; Tue, 12 Nov 2024 20:00:32 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2A24CE07EE for ; Tue, 12 Nov 2024 20:00:32 +0000 (UTC) Message-ID: Date: Tue, 12 Nov 2024 15:00:28 -0500 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: disable setuptools validation of pypi.org allowed strings To: gentoo-dev@lists.gentoo.org References: <20241112172117.2176777-1-eschwartz@gentoo.org> Content-Language: en-US From: Eli Schwartz Autocrypt: addr=eschwartz@gentoo.org; keydata= xjMEZmeRNBYJKwYBBAHaRw8BAQdAYNZ7pUDWhx1i2f3p6L2ZLu4FcY18UoeGC04Gq/khqwfN I0VsaSBTY2h3YXJ0eiA8ZXNjaHdhcnR6QGdlbnRvby5vcmc+wpYEExYKAD4WIQTvUdMIsc4j CIi+DYTqQj6ToWND8QUCZoRL+gIbAwUJBKKGAAULCQgHAwUVCgkICwUWAgMBAAIeBQIXgAAK CRDqQj6ToWND8aB5AP9r4kB691nNtNwKkdRiOdl7/k6WYzokvHvDamXxRJ0I+gEAjZqR5V8y mfR3fy2Z+r2Joeqdt3CIv5IwPs64spBvigLOOARmZ5E0EgorBgEEAZdVAQUBAQdATT46Z06b 1X9xjXFCYFxmq/Tj3tSEKZInDWTpoHQp4l8DAQgHwn4EGBYKACYWIQTvUdMIsc4jCIi+DYTq Qj6ToWND8QUCZmeRNAIbDAUJBKKGAAAKCRDqQj6ToWND8a2RAP40KPfbfoiZAJW5boFmFJ3G TUBDJRh9CWHyaPqq2PN+0wD/R07oLzfnJUN209mzi9TuTuHjeZybysyqXSw4MAxkMAY= In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------5sZtNuKC5Bw19ViI7Kq0LO4a" X-Archives-Salt: 868f8e9d-1795-48f7-8c5d-cff63d9eb95d X-Archives-Hash: 095ff2fdddac82f168f3123d92f4a5d8 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------5sZtNuKC5Bw19ViI7Kq0LO4a Content-Type: multipart/mixed; boundary="------------T68hXqBCgaeTIZ5fWNjOaNmh"; protected-headers="v1" From: Eli Schwartz To: gentoo-dev@lists.gentoo.org Message-ID: Subject: Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: disable setuptools validation of pypi.org allowed strings References: <20241112172117.2176777-1-eschwartz@gentoo.org> In-Reply-To: --------------T68hXqBCgaeTIZ5fWNjOaNmh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/12/24 1:37 PM, Micha=C5=82 G=C3=B3rny wrote: >> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass >> index 7ab8dcae3265..9b9ba4b803ac 100644 >> --- a/eclass/distutils-r1.eclass >> +++ b/eclass/distutils-r1.eclass >> @@ -1360,6 +1360,17 @@ distutils_pep517_install() { >> EOF >> ) >> fi >> + if [[ ${BDEPEND} !=3D *dev-python/trove-classifiers* ]]; then >=20 > It's not valid to access stacked variables like BDEPEND from ebuilds. For what reason is it invalid? Is it about whether this will work correctly or is there a policy reason banning it or... ? Note that this happens inside of a phase function, not at global scope. So the value of the variable is determined by the contents of the environment file, not from the incremental value when sourcing the eclass at global scope. --=20 Eli Schwartz --------------T68hXqBCgaeTIZ5fWNjOaNmh-- --------------5sZtNuKC5Bw19ViI7Kq0LO4a Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTnFNnmK0TPZHnXm3qEp9ErcA0vVwUCZzOz3AUDAAAAAAAKCRCEp9ErcA0vVxEh AQCMKGTv61njN45nYpuT9xrzCb1inszOUVt8ergUnI7TJwD9HXUs5jllqsZaXs9NLQo3S5PGq4xT YWzFX9/Mk/XMvwk= =2w34 -----END PGP SIGNATURE----- --------------5sZtNuKC5Bw19ViI7Kq0LO4a--