From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5586A158083 for ; Wed, 25 Sep 2024 04:27:19 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D4D22E2B49; Wed, 25 Sep 2024 04:27:13 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4567BE2B46 for ; Wed, 25 Sep 2024 04:27:13 +0000 (UTC) Message-ID: Subject: Re: [gentoo-dev] [PATCH] distutils-r1.eclasS: Switch scikit-build-core to build.verbose From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Wed, 25 Sep 2024 06:27:07 +0200 In-Reply-To: <20240924061402.226561-1-mgorny@gentoo.org> References: <20240924061402.226561-1-mgorny@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-dEZXs3SYCCXZlr9c1Qme" User-Agent: Evolution 3.52.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 895f9622-1a53-4183-93ea-e0f77630c76a X-Archives-Hash: 5ed8d9b297b119a57c5837b938646393 --=-dEZXs3SYCCXZlr9c1Qme Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2024-09-24 at 08:14 +0200, Micha=C5=82 G=C3=B3rny wrote: > Replace `cmake.verbose` with `build.verbose`, following the change > in scikit-build-core 0.10. >=20 > Signed-off-by: Micha=C5=82 G=C3=B3rny > --- > eclass/distutils-r1.eclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass > index 5a6ebdcede8a..53b40163c216 100644 > --- a/eclass/distutils-r1.eclass > +++ b/eclass/distutils-r1.eclass > @@ -1339,9 +1339,9 @@ distutils_pep517_install() { > ninjaopts =3D shlex.split(os.environ["NINJAOPTS"]) > print(json.dumps({ > "build.tool-args": ninjaopts, > + "build.verbose": True, > "cmake.args": ";".join(sys.argv[1:]), > "cmake.build-type": "${CMAKE_BUILD_TYPE}", > - "cmake.verbose": True, > "install.strip": False, > })) > EOF Reverting this, since it breaks "older" packages. Upstream literally didn't provide any way for this to work for everyone. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-dEZXs3SYCCXZlr9c1Qme Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmbzkRwSHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQO100H/RgILFWKC273Fh2l7FQC/PUDQ+uREpnC NNA+GvRkVkhwSbuXqrb5nPHHk8YDkvFcTFD87ul7HmSC3LfsP0QiG5BpNjKZeHGl LZqwqdaklXC5ryDwiWeqdtnpgvwUAdQZgc4v3gole1Dn2CCyEmkvgVaDfHrLX+No d0SS/4BL1bJY5JGrxNjBFMkcEHZMDB29MlD5vuLBvpI4xPRSDm/Z9IEPYL3ZDaCK Nh9TvT1o7T7b5YFeP4Tdw9br3reObMEQ0UOWlBVrThSm/mORArHiy1CNb1nzKDvx r0j8wz11Ux6i6jhf4c/5kvSX4oAMlMypQGHeCycGKUBKVXPhW7vXP3c= =0yto -----END PGP SIGNATURE----- --=-dEZXs3SYCCXZlr9c1Qme--