| 1 |
On 04/22/2012 10:04 PM, Steven J Long wrote: |
| 2 |
> It seems there's two major cases, with autotools or without. In either case, |
| 3 |
> epatch_user should be called after Gentoo patches have been applied. |
| 4 |
> |
| 5 |
> Why not make epatch_user set a variable to indicate that patches have been |
| 6 |
> applied, and only apply the patches on the first call? |
| 7 |
> |
| 8 |
> Then eautoreconf could call it before calling autoconf (and the ebuild |
| 9 |
> wouldn't need to worry about it.) And any custom src_prepare function could |
| 10 |
> call it when needed, if it needed to be done during the phase, and not |
| 11 |
> after. |
| 12 |
> |
| 13 |
> After src_prepare, the PM could just call it unconditionally, since it will |
| 14 |
> not apply the patches again, if it's already been called by the ebuild. |
| 15 |
> |
| 16 |
> Does that make sense? |
| 17 |
|
| 18 |
Yeah, sounds roughly equivalent to Ciaran's suggested |
| 19 |
"apply_user_patches_here" approach [1], except that Ciaran suggested to |
| 20 |
make it an error if src_prepare doesn't call apply_user_patches_here (so |
| 21 |
people don't forget to call it when they should). |
| 22 |
|
| 23 |
[1] |
| 24 |
http://archives.gentoo.org/gentoo-dev/msg_c228be85e0c4e577ad194e6004d59062.xml |
| 25 |
-- |
| 26 |
Thanks, |
| 27 |
Zac |
Archives