1 |
On Tue, May 2, 2017 at 1:08 PM, Michał Górny <mgorny@g.o> wrote: |
2 |
|
3 |
> On wto, 2017-05-02 at 12:11 -0700, Zac Medico wrote: |
4 |
> > On Tue, May 2, 2017 at 12:01 PM, Michał Górny <mgorny@g.o> wrote: |
5 |
> > |
6 |
> > > On wto, 2017-05-02 at 11:49 -0700, Zac Medico wrote: |
7 |
> > > > Add forward compatibility up to python3.9. It's helpful to allow some |
8 |
> > > > flexibility in ebuild PYTHON_COMPAT settings, for third-party |
9 |
> > > > repositories that may be used with multiple snapshots of the gentoo |
10 |
> > > > repository. |
11 |
> > > > --- |
12 |
> > > > eclass/python-utils-r1.eclass | 2 +- |
13 |
> > > > 1 file changed, 1 insertion(+), 1 deletion(-) |
14 |
> > > > |
15 |
> > > > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1. |
16 |
> > > |
17 |
> > > eclass |
18 |
> > > > index 66a359e..997a994 100644 |
19 |
> > > > --- a/eclass/python-utils-r1.eclass |
20 |
> > > > +++ b/eclass/python-utils-r1.eclass |
21 |
> > > > @@ -70,7 +70,7 @@ _python_impl_supported() { |
22 |
> > > > python2_7|python3_[456]|jython2_7) |
23 |
> > > > return 0 |
24 |
> > > > ;; |
25 |
> > > > - pypy1_[89]|pypy2_0|python2_[56]|python3_[123]) |
26 |
> > > > + pypy1_[89]|pypy2_0|python2_[56]|python3_[123789]) |
27 |
> > > > return 1 |
28 |
> > > > ;; |
29 |
> > > > pypy|pypy3) |
30 |
> > > |
31 |
> > > Sounds like a very bad idea. How can you even think of adding |
32 |
> > > an implementation if you don't know what the eclass API for it would |
33 |
> be? |
34 |
> > > |
35 |
> > |
36 |
> > For my use case, we're adding python3_6 to PYTHON_COMPAT, and still using |
37 |
> > those ebuilds with older snapshots of the gentoo repository from a few |
38 |
> > months back (as well as newer snapshots). So, there's really no danger in |
39 |
> > my case. |
40 |
> > |
41 |
> > With my suggested change, the eclass doesn't make any API guarantees. |
42 |
> > Where's the harm? |
43 |
> |
44 |
> Unless I'm missing something, this is going to cause the eclass to |
45 |
> accept (and ignore) accidental use of python3_7. It's confusing, to say |
46 |
> the least. |
47 |
> |
48 |
> If you really want to do weird stuff, you're on your own. |
49 |
|
50 |
|
51 |
Okay, I've sent a new patch that adds a PYTHON_IMPLS_NO_STRICT variable. |
52 |
-- |
53 |
Thanks, |
54 |
Zac |