Re: [gentoo-dev] [PATCH] db-use.eclass: add support for EAPI 8, die on unknown EAPI

[Ulrich Mueller]

>>>>> On Fri, 18 Feb 2022, Florian Schmaus wrote:

> -case "${EAPI:-0}" in
> -	0|1|2|3|4|5|6) inherit eapi7-ver multilib ;;
> -	*) inherit multilib ;;
> +case ${EAPI} in
> +	[56]) inherit eapi7-ver ;& # fallthrough
> +	[78]) inherit multilib ;;

Please keep the 5|6) etc. syntax, because it is what is used in almost
all other eclasses. It is also more future proof, EAPI names aren't
limited to a single character.

> +	*) die "${ECLASS}: EAPI ${EAPI} not supported" ;;

Should be ${EAPI:-0} here.

>  esac

More generally, I notice that there is no eclass documentation for any
of the functions.

Also, error handling is a little strange. It outputs a lot of text, but
doesn't die on usage errors. For example:

db_ver_to_slot() {
	if [ $# -ne 1 ]; then
		eerror "Function db_ver_to_slot needs one argument" >&2
		eerror "args given:" >&2
		for f in $@
		do
			eerror " - \"$@\"" >&2
		done
		return 1
	fi
	...
}

Also, f isn't declared as a local variable. In fact, you won't find a
single "local" in the whole eclass.

Ulrich