Re: [gentoo-dev] [PATCH] xorg-2.eclass: Use --disable-selective-werror.

[Matt Turner]

On Sun, Jan 29, 2017 at 12:00 PM, Sergei Trofimovich <slyfox@g.o> wrote:
> On Sun, 29 Jan 2017 11:42:16 -0800
> Matt Turner <mattst88@g.o> wrote:
>
>> Bug: https://bugs.gentoo.org/416069
>> ---
>>  eclass/xorg-2.eclass | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/eclass/xorg-2.eclass b/eclass/xorg-2.eclass
>> index b7c7ba2..7d681f2 100644
>> --- a/eclass/xorg-2.eclass
>> +++ b/eclass/xorg-2.eclass
>> @@ -468,6 +468,11 @@ xorg-2_src_configure() {
>>               local dep_track="--disable-dependency-tracking"
>>       fi
>>
>> +     # Check if package supports disabling of selective -Werror=...
>> +     if grep -q -s "disable-selective-werror" ${ECONF_SOURCE:-.}/configure; then
>> +             local dep_track="--disable-selective-werror"
>
> I guess you planned to use new local var name here (or '+='). Otherwise
> code will drop --disable-dependency-tracking a few lines above.

Derp. Thanks for noticing.