Gentoo Archives: gentoo-dev

From: "Bo ├śrsted Andresen" <zlin@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [RFC] Eclass for gnome-python* split
Date: Mon, 26 May 2008 09:28:22
Message-Id: 200805261127.58407.zlin@gentoo.org
In Reply to: [gentoo-dev] [RFC] Eclass for gnome-python* split by Arun Raghavan
1 On Saturday 24 May 2008 00:01:20 Arun Raghavan wrote:
2 > http://gitorious.org/projects/g-py-split/repos/mainline/blobs/g-py-split/eclass/gnome-python-common.eclass
3
4 Comments to quoted parts of the eclass below...
5
6 > G_PY_BINDINGS=${G_PY_BINDINGS:-${PN%-*}}
7
8 From the comments above it I get the impression that the wildcard is unnecessary:
9
10 G_PY_BINDINGS=${G_PY_BINDINGS:-${PN%-python}}
11
12 > RDEPEND="[...]
13 > =dev-python/${G_PY_PN}-base-${PV}"
14
15 This should probably at least be ~dev-python/${G_PY_PN}-base-${PV} so you don't
16 have to change the eclass whenever you do a revision bump to the base package.
17
18 > if hasq examples ${USE}; then
19
20 This should certainly be:
21
22 if hasq examples ${IUSE} && use examples; then
23
24 It's not clear to me whether you intended to add examples to IUSE for all
25 ebuilds in which case IUSE="examples" should be added to the eclass too...
26 Otherwise all ebuilds that use it must add it to IUSE manually.
27
28 > python_mod_optimize /usr/$(get_libdir)/python${PYVER}/site-packages/gtk-2.0
29
30 Ideally this code would make you inherit multilib explicitly too.
31
32 --
33 Bo Andresen
34 Gentoo KDE Dev

Attachments

File name MIME type
signature.asc application/pgp-signature