Gentoo Archives: gentoo-dev

From: "Marty E. Plummer" <hanetzer@×××××××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 05/10] xdg.eclass: make EAPI 7 ready
Date: Wed, 04 Jul 2018 21:29:06
Message-Id: 20180704212745.a5hljglfr4cxezt4@proprietary-killer
In Reply to: Re: [gentoo-dev] [PATCH 05/10] xdg.eclass: make EAPI 7 ready by "Michał Górny"
1 On Wed, Jun 27, 2018 at 08:37:04AM +0200, Michał Górny wrote:
2 > W dniu śro, 27.06.2018 o godzinie 06∶58 +0200, użytkownik Ulrich Mueller
3 > napisał:
4 > > > > > > > On Tue, 26 Jun 2018, Marty E Plummer wrote:
5 > > > Add dev-util/desktop-file-utils and x11-misc/shared-mime-info to BDEPEND
6 > > > as a number of executables which will need to be executed on the build
7 > > > host are included in them.
8 > > > Package-Manager: Portage-2.3.40, Repoman-2.3.9
9 > > > ---
10 > > > eclass/xdg.eclass | 3 ++-
11 > > > 1 file changed, 2 insertions(+), 1 deletion(-)
12 > > > diff --git a/eclass/xdg.eclass b/eclass/xdg.eclass
13 > > > index 2a4e1f81abf..fc4bee30ca5 100644
14 > > > --- a/eclass/xdg.eclass
15 > > > +++ b/eclass/xdg.eclass
16 > > > @@ -26,6 +26,7 @@ DEPEND="
17 > > > dev-util/desktop-file-utils
18 > > > x11-misc/shared-mime-info
19 > > > "
20 > > > +[[ ${EAPI:-0} == [0123456] ]] || BDEPEND="${DEPEND}"
21 > >
22 > > Are these also needed in DEPEND? If not, you should set DEPEND="" in
23 > > EAPI 7.
24 > >
25 >
26 > Technically, they don't belong in either because they're run
27 > in pkg_post* phases only.
28 >
29 https://projects.gentoo.org/pms/7/pms.html#x1-680008.1
30 According to this, if I read it right, pkg_{pre,post}{inst,rm} deps
31 should go into PDEPEND; is that still correct in terms of EAPI7 and
32 such?
33 > --
34 > Best regards,
35 > Michał Górny