Gentoo Archives: gentoo-dev

From: Justin <jlec@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild
Date: Fri, 03 May 2013 18:18:52
Message-Id: 5183FF82.5070601@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild by Samuli Suominen
1 On 03/05/13 19:56, Samuli Suominen wrote:
2 > On 03/05/13 20:33, Justin Lecher (jlec) wrote:
3 >> jlec 13/05/03 17:33:56
4 >>
5 >> Modified: metadata.xml ChangeLog
6 >> Added: id3lib-3.8.3-r9.ebuild
7 >> Log:
8 >> media-libs/id3lib: Fix obsolete macros to work with automake-1.13,
9 >> #467704; bumped to EAPI=5 and autotools-utils.eclass
10 >>
11 >> (Portage version: 2.2.0_alpha173/cvs/Linux x86_64, signed Manifest
12 >> commit with key 8009D6F070EB7916)
13 >>
14 >> Revision Changes Path
15 >> 1.3 media-libs/id3lib/metadata.xml
16 >>
17 >> file :
18 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?rev=1.3&view=markup
19 >>
20 >> plain:
21 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?rev=1.3&content-type=text/plain
22 >>
23 >> diff :
24 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?r1=1.2&r2=1.3
25 >>
26 >>
27 >> Index: metadata.xml
28 >> ===================================================================
29 >> RCS file: /var/cvsroot/gentoo-x86/media-libs/id3lib/metadata.xml,v
30 >> retrieving revision 1.2
31 >> retrieving revision 1.3
32 >> diff -u -r1.2 -r1.3
33 >> --- metadata.xml 16 Jul 2009 19:18:11 -0000 1.2
34 >> +++ metadata.xml 3 May 2013 17:33:56 -0000 1.3
35 >> @@ -1,5 +1,5 @@
36 >> <?xml version="1.0" encoding="UTF-8"?>
37 >> <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
38 >> <pkgmetadata>
39 >> - <herd>sound</herd>
40 >> + <herd>sound</herd>
41 >> </pkgmetadata>
42 >
43 > What's the point of kludging unrelated commits like this one...?
44
45 You personally told me, that you want to have metadata.xml indented with
46 two spaces. Did you change your own style?
47
48 >
49 >>
50 >>
51 >>
52 >> 1.81 media-libs/id3lib/ChangeLog
53 >>
54 >> file :
55 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?rev=1.81&view=markup
56 >>
57 >> plain:
58 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?rev=1.81&content-type=text/plain
59 >>
60 >> diff :
61 >> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?r1=1.80&r2=1.81
62 >>
63 >>
64 >> Index: ChangeLog
65 >> ===================================================================
66 >> RCS file: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v
67 >> retrieving revision 1.80
68 >> retrieving revision 1.81
69 >> diff -u -r1.80 -r1.81
70 >> --- ChangeLog 22 Mar 2012 12:33:36 -0000 1.80
71 >> +++ ChangeLog 3 May 2013 17:33:56 -0000 1.81
72 >> @@ -1,6 +1,13 @@
73 >> # ChangeLog for media-libs/id3lib
74 >> -# Copyright 1999-2012 Gentoo Foundation; Distributed under the GPL v2
75 >> -# $Header: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v 1.80
76 >> 2012/03/22 12:33:36 ssuominen Exp $
77 >> +# Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
78 >> +# $Header: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v 1.81
79 >> 2013/05/03 17:33:56 jlec Exp $
80 >> +
81 >> +*id3lib-3.8.3-r9 (03 May 2013)
82 >> +
83 >> + 03 May 2013; Justin Lecher <jlec@g.o> +id3lib-3.8.3-r9.ebuild,
84 >> + metadata.xml:
85 >> + Fix obsolete macros to work with automake-1.13, #467704; bumped to
86 >> EAPI=5 and
87 >> + autotools-utils.eclass
88 >
89 > There was no reason to use autotools-utils.eclass in the ebuild.
90
91 Any reason to not using it?

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies