Gentoo Archives: gentoo-dev

From: Thomas Cort <tcort@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] variable quoting, setting optional variables to "", and depending on virtual/libc
Date: Sat, 17 Jun 2006 04:38:52
Message-Id: 20060617003530.f5cf7488.tcort@gentoo.org
1 What is the proper quoting style for using epatch? In the tree there
2 are about 3 different styles...
3
4 epatch ${FILESDIR}/some-fix.patch # used by 7326 ebuilds
5 epatch "${FILESDIR}"/some-fix.patch # used by 3092 ebuilds
6 epatch "${FILESDIR}/some-fix.patch" # used by 1434 ebuilds
7
8 What is the proper quoting style for defining the S variable? In the
9 tree there are about 3 different styles...
10
11 S=${WORKDIR}/${MY_P} # used by 5270 ebuilds
12 S="${WORKDIR}"/${MY_P} # used by 43 ebuilds
13 S="${WORKDIR}/${MY_P}" # used by 2259 ebuilds
14
15 What is the purpose of setting DEPEND and RDEPEND to "" if DEPEND and
16 RDEPEND are optional[1][2]? Isn't that just a waste of disk space /
17 bandwidth? DEPEND="virtual/libc" seems like a waste too as it is an
18 implicit system dependency[3], any reason for using it?
19
20 DEPEND="" # used by 1479 ebuilds
21 RDEPEND="" # used by 884 ebuilds
22 DEPEND="virtual/libc" # used by 809 ebuilds
23
24 [1] http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1#doc_chap_pre2
25 [2] http://devmanual.gentoo.org/ebuild-writing/variables/index.html#optional-variables
26 [3] http://devmanual.gentoo.org/general-concepts/dependencies/index.html#implicit-system-dependency

Replies