Gentoo Archives: gentoo-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] repoman and checking for correct quoting
Date: Sat, 10 Nov 2007 17:13:39
Message-Id: 4735E60C.9020805@gentoo.org
In Reply to: [gentoo-dev] repoman and checking for correct quoting by Krzysiek Pawlik
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Krzysiek Pawlik wrote:
5 > Consider following part of scite-1.74.ebuild:
6 >
7 > sed -i makefile \
8 > -e 's#usr/local#usr#g' \
9 > -e 's#/gnome/apps/Applications#/applications#' \
10 > -e "s#^CXXFLAGS=#CXXFLAGS=${CXXFLAGS} #" \
11 > -e "s#^\(CXXFLAGS=.*\)-Os#\1#" \
12 > -e "s#^CC =\(.*\)#CC = $(tc-getCXX)#" \
13 > -e 's#${D}##' \
14 > -e 's#-g root#-g 0#' \
15 > || die "error patching makefile"
16 >
17 > `repoman full' catches line "-e 's#${D}##' \":
18 >
19 > app-editors/scite/scite-1.74.ebuild: Unquoted Variable on line: 41
20 >
21 > It's purpose is to remove the ${D} from makefile, additionally ${D} is in single
22 > quotes, so it will not be expanded - is it a bug in repoman check?
23
24 Yes, it seems like we need to add an exemption for variables inside
25 single quotes like that.
26
27 Zac
28 -----BEGIN PGP SIGNATURE-----
29 Version: GnuPG v2.0.7 (GNU/Linux)
30
31 iD8DBQFHNeYL/ejvha5XGaMRAkpqAJ4tQzDDhcRbfFFqbYhGM3jm+iO6ZACfdovW
32 +1DwScsWViapX7BJnD10lAM=
33 =BBQu
34 -----END PGP SIGNATURE-----
35 --
36 gentoo-dev@g.o mailing list