Gentoo Archives: gentoo-dev

From: Ian Stakenvicius <axs@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] redundant code in toolchain.eclass?
Date: Wed, 26 Oct 2011 16:03:39
Message-Id: 4EA82F1D.6010200@gentoo.org
In Reply to: [gentoo-dev] redundant code in toolchain.eclass? by "Paweł Hajdan
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 26/10/11 10:20 AM, "Paweł Hajdan, Jr." wrote:
5 > I was browsing toolchain.eclass and noticed this:
6 >
7 > if [[ ${PN} != "kgcc64" && ${PN} != gcc-* ]] ; then
8 > ...
9 > [[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
10 > ...
11 >
12 > if tc_version_is_at_least 3 ; then
13 > ...
14 > if tc_version_is_at_least "4.4" ; then
15 > IUSE+=" graphite"
16 > [[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
17 > fi
18 > ...
19 > fi
20 > fi
21 >
22 > The second IUSE+=" nossp" seems redundant and could be removed, right?
23 >
24
25 'nossp' is in IUSE twice within my copy of portage's metadata/cache file
26 for gcc, so it would seem there are at least some cases where it is
27 redundant.
28
29
30
31 -----BEGIN PGP SIGNATURE-----
32 Version: GnuPG v2.0.17 (GNU/Linux)
33
34 iF4EAREIAAYFAk6oLx0ACgkQAJxUfCtlWe2S9QD+K9nyvwsajNXvLRQnzFQJ+mVh
35 Gb16haS0Yy321JEusmsBANSBq6RrODFyGb9q5KIIxf5ZWfopWqAC/63Zwg5MRJU5
36 =jcLT
37 -----END PGP SIGNATURE-----