Gentoo Archives: gentoo-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] [PATCH] distutils-r1.eclass, drop unused egg-base settings
Date: Tue, 29 Nov 2016 23:57:27
Message-Id: 20161129155716.1a6c7f78.dolsen@gentoo.org
1 While working on the last 2 version bumps to the twisted package, I
2 kept getting an error in which the *egg-info/SOURCES.txt file absolute
3 paths for all the files found in that very same directory. They are
4 required to be relative paths only. This problem currently only affects
5 some pkgs depending on the setuptools pkg for install. The source of
6 the change is that setuptools patches the cpython findall() with one
7 that returns relative paths for anything in/below the passed in base
8 directory. Everything else it returns the absolute path.
9
10 Why we should apply this:
11
12 Python upstream has merged the setuptools findall() code and will be
13 included in the next releases of python, 2.7.13, 3.4.6, 3.5.4 (I
14 think). So, there is potential for many more python pkgs to be
15 affected by this that are not requiring setuptools for install.
16 Without the ebb-base setting, the egg-info/* files are not included
17 in SOURCES.txt. The install proceeds without error.
18
19 NOTE: This first affects the python_compile_all phase, long before
20 it even tries to run the tests (if enabled).
21
22
23 Some history:
24
25 The egg-base settings were originally added for parallel
26 testing/install purposes. They are not used due to problems in
27 parallelizing testing, etc.. (something along those lines, I
28 don't want to search thru the logs, and mails to see what Michal's
29 original words were about it.)
30
31 I am working on twisted-16.5.0 and 16.6.0 releases (tests are still
32 failing), but 16.6.0 has many improvements to the testing code, so has a
33 lot fewer errors to fix. Once these are fixed and the eclass changes
34 are merged, I will be able to add it to the tree.
35
36 See attached patch. NOTE: actual commit message will be
37 different/updated correctly. This was just an interim patch for
38 testing and initial review.
39
40 --
41 Brian Dolbec <dolsen>

Attachments

File name MIME type
0001-remove-setting_egginfo_egg-base_setting.patch text/x-patch

Replies