Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Yiyang Wu <xgreenlandforwyy@×××××.com>
Cc: gentoo-dev@l.g.o, Benda Xu <heroxbd@g.o>
Subject: [gentoo-dev] Re: [PATCH v4 0/2] *** rocm.eclass: new eclass ***
Date: Sun, 28 Aug 2022 06:36:46
Message-Id: uler8ri1a@gentoo.org
In Reply to: [gentoo-dev] [PATCH v4 0/2] *** rocm.eclass: new eclass *** by Yiyang Wu
1 >>>>> On Sun, 28 Aug 2022, Yiyang Wu wrote:
2
3 > - if has ${gpu_target} "${OFFICIAL_AMDGPU_TARGETS[*]}"; then
4 > + if has "${gpu_target}" ${OFFICIAL_AMDGPU_TARGETS[*]}; then
5
6 This still doesn't look right. It should be:
7
8 if has "${gpu_target}" "${OFFICIAL_AMDGPU_TARGETS[@]}"; then
9
10 From Bash documentation:
11
12 | If the word is double-quoted, '${NAME[*]}' expands to a single word
13 | with the value of each array member separated by the first character
14 | of the 'IFS' variable, and '${NAME[@]}' expands each element of NAME
15 | to a separate word.
16
17 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature