1 |
On Friday 15 June 2012 03:44:14 Samuli Suominen wrote: |
2 |
> On 06/13/2012 06:02 AM, Mike Frysinger wrote: |
3 |
> > i've noticed a growing trend where people put setup of variables into |
4 |
> > pkg_setup that only matter to src_* funcs presumably so they don't have |
5 |
> > to call the respective src_* func from an inherited eclass. |
6 |
> > unfortunately this adds pointless overhead to binpkgs. can we please |
7 |
> > move away from this practice ? |
8 |
> |
9 |
> Every Xfce ebuild in gentoo-x86 is using pkg_setup() for 3 variables, |
10 |
> DOCS for src_install, PATCHES for src_prepare |
11 |
|
12 |
these are static variables, so defining them in a func is pointless |
13 |
|
14 |
> and XFCONF for src_configure |
15 |
|
16 |
now you're down to one variable which means you've got one func to /properly/ |
17 |
define |
18 |
-mike |