[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-sound/kid3: metadata.xml kid3-2.1.ebuild ChangeLog

[Michael Palimaka]

On 2012-06-07 23:06, Samuli Suominen wrote:
> On 06/07/2012 04:06 PM, Michael Palimaka (kensington) wrote:
>> kensington 12/06/07 13:06:48
>>
>> Modified: metadata.xml ChangeLog
>> Added: kid3-2.1.ebuild
>> Log:
>> Version bump. Add upstream metadata.
>>
>> (Portage version: 2.1.10.65/cvs/Linux x86_64)
>>
>> Revision Changes Path
>> 1.5 media-sound/kid3/metadata.xml
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/kid3/metadata.xml?rev=1.5&view=markup
>>
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/kid3/metadata.xml?rev=1.5&content-type=text/plain
>>
>> diff :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/kid3/metadata.xml?r1=1.4&r2=1.5
>>
>>
>> Index: metadata.xml
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/media-sound/kid3/metadata.xml,v
>> retrieving revision 1.4
>> retrieving revision 1.5
>> diff -u -r1.4 -r1.5
>> --- metadata.xml 21 Aug 2009 14:36:01 -0000 1.4
>> +++ metadata.xml 7 Jun 2012 13:06:48 -0000 1.5
>> @@ -3,4 +3,12 @@
>> <pkgmetadata>
>> <herd>kde</herd>
>> <herd>sound</herd>
>> + <use>
>> + <flag name="chroma">Enable support for acoustic fingerprinting
>> plugin using
>> + (<pkg>media-libs/chromaprint</pkg>)</flag>
>> + </use>
>> + <upstream>
>> + <bugs-to>http://sourceforge.net/tracker/?group_id=70849</bugs-to>
>> + <remote-id type="sourceforge">kid3</remote-id>
>> + </upstream>
>> </pkgmetadata>
>>
>>
>>
>> 1.61 media-sound/kid3/ChangeLog
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/kid3/ChangeLog?rev=1.61&view=markup
>>
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/kid3/ChangeLog?rev=1.61&content-type=text/plain
>>
>> diff :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/kid3/ChangeLog?r1=1.60&r2=1.61
>>
>>
>> Index: ChangeLog
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/media-sound/kid3/ChangeLog,v
>> retrieving revision 1.60
>> retrieving revision 1.61
>> diff -u -r1.60 -r1.61
>> --- ChangeLog 19 May 2012 09:07:30 -0000 1.60
>> +++ ChangeLog 7 Jun 2012 13:06:48 -0000 1.61
>> @@ -1,6 +1,12 @@
>> # ChangeLog for media-sound/kid3
>> # Copyright 1999-2012 Gentoo Foundation; Distributed under the GPL v2
>> -# $Header: /var/cvsroot/gentoo-x86/media-sound/kid3/ChangeLog,v 1.60
>> 2012/05/19 09:07:30 ssuominen Exp $
>> +# $Header: /var/cvsroot/gentoo-x86/media-sound/kid3/ChangeLog,v 1.61
>> 2012/06/07 13:06:48 kensington Exp $
>> +
>> +*kid3-2.1 (07 Jun 2012)
>> +
>> + 07 Jun 2012; Michael Palimaka <kensington@g.o> +kid3-2.1.ebuild,
>> + metadata.xml:
>> + Version bump. Add upstream metadata.
>>
>> 19 May 2012; Samuli Suominen <ssuominen@g.o> kid3-1.4.ebuild,
>> kid3-2.0.1.ebuild:
>>
>>
>>
>> 1.1 media-sound/kid3/kid3-2.1.ebuild
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/kid3/kid3-2.1.ebuild?rev=1.1&view=markup
>>
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/kid3/kid3-2.1.ebuild?rev=1.1&content-type=text/plain
>>
>>
>> Index: kid3-2.1.ebuild
>> ===================================================================
>> # Copyright 1999-2012 Gentoo Foundation
>> # Distributed under the terms of the GNU General Public License v2
>> # $Header: /var/cvsroot/gentoo-x86/media-sound/kid3/kid3-2.1.ebuild,v
>> 1.1 2012/06/07 13:06:48 kensington Exp $
>>
>> EAPI=4
>> KDE_LINGUAS="cs de es et fi fr it nl pl ru sr sr@ijekavian
>> sr@ijekavianlatin sr@Latn tr zh_TW"
>> KDE_REQUIRED="always"
>> KDE_HANDBOOK="optional"
>> inherit kde4-base
>>
>> DESCRIPTION="A simple tag editor for KDE"
>> HOMEPAGE="http://kid3.sourceforge.net/"
>> SRC_URI="mirror://sourceforge/${PN}/${P}.tar.gz"
>>
>> LICENSE="GPL-2"
>> SLOT="4"
>> KEYWORDS="~amd64 ~x86"
>> IUSE="chroma flac mp3 mp4 +taglib vorbis"
>>
>> RDEPEND="
>> chroma? (
>> media-libs/chromaprint
>> virtual/ffmpeg
>> )
>> flac? (
>> media-libs/flac[cxx]
>> media-libs/libvorbis
>> )
>> mp3? ( media-libs/id3lib )
>> mp4? ( media-libs/libmp4v2:0 )
>> taglib? ( media-libs/taglib )
>> vorbis? (
>> media-libs/libogg
>> media-libs/libvorbis
>> )"
>> DEPEND="${RDEPEND}"
>>
>> REQUIRED_USE="flac? ( vorbis )"
>>
>> src_configure() {
>> local mycmakeargs=(
>> $(cmake-utils_use_with chroma CHROMAPRINT)
>> $(cmake-utils_use_with flac)
>> $(cmake-utils_use_with mp3 ID3LIB)
>> $(cmake-utils_use_with mp4 MP4V2)
>> $(cmake-utils_use_with vorbis)
>> $(cmake-utils_use_with taglib)
>> "-DWITH_TUNEPIMP=OFF"
>> "-DWITH_KDE=ON"
>
> No such flag as WITH_TUNEPIMP in 2.1 release anymore.
Good catch, thanks for noticing.

>
> And the build system should now work so that USE="kde" can be added with
> KDE_REQUIRED=optional.
I did test that, however was unable to make it work correctly. YMMV.

>
> (I was writing ebuild for this too, and it looks very much like what you
> have except these 2 issues.)
Great minds think alike. ;-)

>
> - Samuli

Michael