Gentoo Archives: gentoo-dev

From: Samuli Suominen <ssuominen@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in profiles/default/linux: make.defaults
Date: Mon, 12 Jul 2010 12:58:36
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in profiles/default/linux: make.defaults by Jeremy Olexa
On 07/12/2010 03:50 PM, Jeremy Olexa wrote:
> On 07/12/2010 12:12 AM, Samuli Suominen wrote: >> On 07/12/2010 07:53 AM, Jeremy Olexa wrote: >>> On 07/11/2010 02:50 PM, Samuli Suominen (ssuominen) wrote: >>>> -LDFLAGS="-Wl,-O1" >>>> +LDFLAGS="-Wl,-O1 ${LDFLAGS}" >>> >>> My existing, custom, entry for LDFLAGS breaks with this change. Not >>> nice. >>> >>> %% grep LDFLAGS /etc/make.conf >>> LDFLAGS="${LDFLAGS},--hash-style=gnu -Wl,--as-needed" >>> >>> -Jeremy >> >> that only worked before because of a fluke (= profiles had only one >> LDFLAGS before). >> it's not valid to assume -Wl gets passed from previous instance and >> leave next ones dangling. >> > > Ok, I thought it was alittle "funny" to change a variable's behavior > from non-stacking to stacking. If no one else has a problem with it, I > will just change my make.conf and get over it. No worries. > > -Jeremy >
in fact, on related issue... the whitespace generated by that approach had a negative impact on dev-util/boost-build which is error prone to them so it got changed, your flags should work again (although they are too clever :-) - Samuli