Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Ulrich Mueller <ulm@g.o>
Cc: Gentoo Dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] [PATCH] epatch.eclass: call ebegin to balance eend
Date: Tue, 28 Jun 2022 18:09:04
Message-Id: CAJ0EP401QLqmmPVQ10dp710jf+O_x7t53_Oops4fa-EPf49Jiw@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH] epatch.eclass: call ebegin to balance eend by Ulrich Mueller
1 On Tue, Jun 28, 2022 at 2:05 AM Ulrich Mueller <ulm@g.o> wrote:
2 >
3 > >>>>> On Mon, 27 Jun 2022, Mike Gilbert wrote:
4 >
5 > > if [[ ${SINGLE_PATCH} == "yes" ]] ; then
6 > > if [[ -n ${EPATCH_SINGLE_MSG} ]] ; then
7 > > - einfo "${EPATCH_SINGLE_MSG}"
8 > > + ebegin "${EPATCH_SINGLE_MSG}"
9 > > else
10 > > - einfo "Applying ${patchname} ..."
11 > > + ebegin "Applying ${patchname}"
12 > > fi
13 >
14 > EPATCH_SINGLE_MSG isn't used in the tree, so this could be simplified to
15 > have the "else" part only, and delete the eclass variable. (Strange idea
16 > to make this message configurable, in the first place.)
17 >
18 > > else
19 > > - einfo " ${patchname} ..."
20 > > + ebegin " ${patchname}"
21 > > fi
22 >
23 > Maybe drop support for EAPIs 0 to 4 while at it?
24
25 I made both changes on the github PR.
26
27 https://github.com/gentoo/gentoo/pull/26122