Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in mail-filter/dspam: ChangeLog dspam-3.8.0-r7.ebuild
Date: Mon, 01 Oct 2007 08:16:21
Message-Id: 20071001080423.GV28813@supernova
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in mail-filter/dspam: ChangeLog dspam-3.8.0-r7.ebuild by "Alin Năstac"
1 On 10:43 Mon 01 Oct , Alin Năstac wrote:
2 > Donnie Berkholz wrote:
3 > > It's better to do something smart than to force interactivity. In this
4 > > case, you as the maintainer would decide whether this USE combo meant
5 > > the user wanted virtual-users (if so, forcibly enable one of mysql or
6 > > postgres), or whether the user definitely did not want to pull in a
7 > > database (if so, force off virtual-users).
8 > >
9 > I cannot force mysql or postgres dependency just because user enabled
10 > virtual-users flag.
11 > IMO this case would definitely qualify for a pkg_setup die because
12 > virtual-users is a local useflag. By selecting virtual-users without
13 > enabling mysql or postgres storage backend, the user proved to be
14 > clueless and ebuild should provide the much needed clue.
15
16 One way to proceed is to not have both mysql and postgres as USE flags.
17 Have one as a flag, and have negation of that flag mean to use the
18 other. Does that make sense for this package, or can they both
19 reasonably be used at the same time?
20
21 I strongly discourage dying here; do something smart and log a warning
22 to the user about it.
23
24 Thanks,
25 Donnie
26 --
27 gentoo-dev@g.o mailing list

Replies