| 1 |
On Tue, Aug 15, 2017 at 5:19 AM, <tomjbe@g.o> wrote: |
| 2 |
> Quoting Michał Górny (2017-08-15 08:43:07) |
| 3 |
>> On wto, 2017-08-15 at 06:55 +0200, tomjbe@g.o wrote: |
| 4 |
>> > Quoting Rich Freeman (2017-08-15 00:29:19) |
| 5 |
>> > > |
| 6 |
>> > > I guess to make it a bit more explicit, would it make sense to have 3 flags: |
| 7 |
>> > > |
| 8 |
>> > > client - install the client (or consider calling it file-daemon instead) |
| 9 |
>> > > director - install the director |
| 10 |
>> > > storage-daemon - install the storage daemon |
| 11 |
>> > > |
| 12 |
>> > |
| 13 |
>> > That would be best, but it is not supported by their (autoconf based) build |
| 14 |
>> > system (and would require a complete rewrite of it). The actual USE flags |
| 15 |
>> > mostly mirrors the switches from the configure script. You can not set them as |
| 16 |
>> > you like, they are not orthogonal E.g. the file deamon (client) will be |
| 17 |
>> > installed unconditionally. |
| 18 |
>> > |
| 19 |
>> > The configure script itself is very brittle atm and needs an urgent overhaul. |
| 20 |
>> > Discussion with upstream goes a long way, but they do not want to change it |
| 21 |
>> > because of the need to retest it on very different systems. No good situation. |
| 22 |
>> > |
| 23 |
>> > A possible idea may be to drop the 'no/client' flag completely. If neither |
| 24 |
>> > 'director' nor 'storage-daemon' is active all that is left would be the |
| 25 |
>> > file daemon. |
| 26 |
>> > What do you think? |
| 27 |
>> |
| 28 |
>> WFM. If the flag doesn't do anything except for disabling the two other |
| 29 |
>> flags, then there's no place for such a flag. |
| 30 |
>> |
| 31 |
> And here comes the problem. USE="bacula-nodir bacula-nosd" does not produce |
| 32 |
> the same set of files as USE="bacula-clientonly". But I will recheck if the |
| 33 |
> difference is of relevance for normal gentoo user. |
| 34 |
|
| 35 |
It is probably worth understanding the difference. However, if the |
| 36 |
user sets both -director and -storage-daemon you could also enable |
| 37 |
bacula-clientonly, unless there is some reason somebody might want two |
| 38 |
of those and not the third. |
| 39 |
|
| 40 |
> |
| 41 |
>> > |
| 42 |
>> > The downside of that idea is that we diverge from baculas documentation which |
| 43 |
>> > explicitly state that there is a 'clientonly' install. |
| 44 |
>> > |
| 45 |
>> |
| 46 |
>> Upstream install documentation is not relevant to Gentoo. The flag |
| 47 |
>> descriptions in metadata.xml are. |
| 48 |
>> |
| 49 |
> Right. But if we drop a "clientonly" than there is no hint in metadata.xml how |
| 50 |
> to get only the file daemon alone. Some einfo output or similar come to mind. |
| 51 |
> |
| 52 |
|
| 53 |
You could use einfo. However, if the docs say what the other two |
| 54 |
flags do then it seems pretty obvious that if you turn them both off |
| 55 |
you end up with only the file daemon. |
| 56 |
|
| 57 |
-- |
| 58 |
Rich |
Archives