| 1 |
On 01/16/2012 02:54 AM, "Paweł Hajdan, Jr." wrote: |
| 2 |
> People frequently break their systems by exporting weird variables like |
| 3 |
> SYSTEM from /etc/make.conf (USE variable "grouping"). |
| 4 |
> |
| 5 |
> Example here: <http://forums.gentoo.org/viewtopic.php?p=6915550#6915550> |
| 6 |
> |
| 7 |
> What do you think about adding list of variables in make.conf to emerge |
| 8 |
> --info ? I know we can always ask for the make.conf, but it either |
| 9 |
> requires asking for a large amount of info up front, or increases the |
| 10 |
> number of round-trips (emerge --info looks normal, ask for make.conf). |
| 11 |
|
| 12 |
Sensitive variables fall into at least 2 categories: |
| 13 |
|
| 14 |
(1) Variables that the user may have a valid reason to set, though |
| 15 |
the value needs to be valid if it is set. An example might be the |
| 16 |
COLUMNS variable, which can trigger bug 394091 [1]. |
| 17 |
|
| 18 |
(2) Variables which may case a build to fail and there is no valid |
| 19 |
reason for the user to set them in the context of a particular |
| 20 |
ebuild. An example might be the SYSTEM variables, which can trigger |
| 21 |
bug 372519 [2]. |
| 22 |
|
| 23 |
For case (2) it makes sense for ebuilds to explicitly unset or export -n |
| 24 |
the relevant variables, since those variables only serve to allow the |
| 25 |
users to hurt themselves. |
| 26 |
|
| 27 |
[1] https://bugs.gentoo.org/show_bug.cgi?id=394091 |
| 28 |
[2] https://bugs.gentoo.org/show_bug.cgi?id=372519 |
| 29 |
-- |
| 30 |
Thanks, |
| 31 |
Zac |
Archives