1 |
On 00:04 Tue 07 Aug , Bernard Cafarelli wrote: |
2 |
> Latest version of the base eclass (sent with this mail) can be found at: |
3 |
> http://overlays.gentoo.org/proj/gnustep/browser/overlay/eclass/gnustep-base.eclass |
4 |
> |
5 |
> This one does most of the hard work, especially in egnustep_env which |
6 |
> sets up an appropriate GNUstep compilation environment from the |
7 |
> installed gnustep-make. |
8 |
|
9 |
Some suggestions on the eclass ... |
10 |
|
11 |
Instead of your eval trick, try something like what's in molden-4.6.ebuild: |
12 |
|
13 |
typeset -a args |
14 |
args=( CC="$(tc-getCC) ${CFLAGS}" \ |
15 |
FC="${FORTRANC}" LDR="${FORTRANC}" FFLAGS="${FFLAGS}" ) |
16 |
|
17 |
emake -j1 "${args[@]}" || die "molden emake failed" |
18 |
|
19 |
Some of your die() calls lack messages. Please add them. |
20 |
|
21 |
I like a little different setup for this type of function: |
22 |
117 egnustep_make() { |
23 |
118 if [ -f ./[mM]akefile -o -f ./GNUmakefile ] ; then |
24 |
119 eval emake ${*} ${__GS_MAKE_EVAL} all || die "package make failed" |
25 |
120 else |
26 |
121 die "no Makefile found" |
27 |
122 fi |
28 |
123 } |
29 |
|
30 |
Instead... |
31 |
117 egnustep_make() { |
32 |
118 if [ -f ./[mM]akefile -o -f ./GNUmakefile ] ; then |
33 |
119 eval emake ${*} ${__GS_MAKE_EVAL} all || die "package make failed" |
34 |
120 return 0 |
35 |
121 fi |
36 |
122 die "no Makefile found" |
37 |
123 } |
38 |
|
39 |
But that's just a matter of preference. Same kinda deal for egnustep_install(). |
40 |
|
41 |
Thanks, |
42 |
Donnie |
43 |
-- |
44 |
gentoo-dev@g.o mailing list |