Gentoo Archives: gentoo-dev

From: Michael Orlitzky <mjo@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] xorg-3.eclass: Copy from xorg-2.eclass and add EAPI 7 support
Date: Thu, 21 Feb 2019 12:50:25
Message-Id: 9bfaa289-250b-9701-77e4-a187500d03c2@gentoo.org
In Reply to: [gentoo-dev] [PATCH] xorg-3.eclass: Copy from xorg-2.eclass and add EAPI 7 support by Matt Turner
1 On 2/21/19 1:09 AM, Matt Turner wrote:
2 >
3 > 2) Suggestions welcome for solving https://bugs.gentoo.org/637898
4 > I have no ideas...
5 >
6
7 The eclass documentation script wants a fixed default value for
8 variables that are optional.
9
10 For XORG_MODULE, instead of a case statement,
11
12 if [[ -z ${XORG_MODULE} ]]; then
13 case ${CATEGORY} in
14 app-doc) XORG_MODULE=doc/ ;;
15 media-fonts) XORG_MODULE=font/ ;;
16 ...
17
18 you could make the default value "auto" (or some other magic value), and
19 then document that "auto" will guess based on the package's category.
20
21 The same thing should work for XORG_MODULE_REBUILD. First, I would
22 ensure that DRIVER is set to either "yes" or "no" (right now it can be
23 empty, I think). Then make the default value for XORG_MODULE_REBUILD
24 something like "auto", and do
25
26 if [[ "${XORG_MODULE_REBUILD}" == auto ]]; then
27 XORG_MODULE_REBUILD="${DRIVER}"
28 fi