Gentoo Archives: gentoo-dev

From: William Hubbs <williamh@g.o>
To: gentoo-dev@l.g.o
Cc: ulm@g.o
Subject: Re: [gentoo-dev] [PATCH] skel.ebuild: Update comments for inherit, SLOT, KEYWORDS.
Date: Sun, 31 Dec 2017 18:12:54
Message-Id: 20171231181246.GA14636@linux1.home
In Reply to: Re: [gentoo-dev] [PATCH] skel.ebuild: Update comments for inherit, SLOT, KEYWORDS. by "Michał Górny"
1 On Sun, Dec 31, 2017 at 06:44:39PM +0100, Michał Górny wrote:
2 > W dniu nie, 31.12.2017 o godzinie 14∶31 +0100, użytkownik Ulrich Müller
3 > napisał:
4 > > epatch() is provided by epatch.eclass now. Also comment the inherit
5 > > line, since not every ebuild will use it.
6 > >
7 > > Empty SLOT doesn't disable slots, but is outright illegal in all EAPIs.
8 > > Similar for KEYWORDS="*", which isn't "deprecated" but invalid.
9 > > ---
10 > > skel.ebuild | 9 ++++-----
11 > > 1 file changed, 4 insertions(+), 5 deletions(-)
12 > >
13 > > diff --git a/skel.ebuild b/skel.ebuild
14 > > index 7ac9dfb7d6d8..4c19b1de4cb8 100644
15 > > --- a/skel.ebuild
16 > > +++ b/skel.ebuild
17 > > @@ -13,9 +13,9 @@
18 > > EAPI=6
19 > >
20 > > # inherit lists eclasses to inherit functions from. For example, an ebuild
21 > > -# that needs the epatch function from eutils.eclass won't work without the
22 > > +# that needs the epatch function from epatch.eclass won't work without the
23 > > # following line:
24 > > -inherit eutils
25 > > +#inherit epatch
26 >
27 > Well, given that it's EAPI 6 and we do not want to encourage people to
28 > use epatch there, I would prefer if we replaced that example with
29 > something else. But it's just a wishful thinking here.
30
31 +1, but I'm not going to suggest what to replace it with.
32
33 William

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies