1 |
On Thu, 4 Apr 2013 10:07:06 +0200 |
2 |
Alexis Ballier <aballier@g.o> wrote: |
3 |
|
4 |
> > It will be when there's a safe, public API for it. Right now, it's too |
5 |
> > fragile. |
6 |
> |
7 |
> What exactly is the unsafe part of the API of this function ? |
8 |
|
9 |
Well, the first thing was using $ABI directly, and I sent a patch for |
10 |
that one already. |
11 |
|
12 |
> You could |
13 |
> very well make it functional by replacing MULTILIB_WRAPPED_HEADERS by |
14 |
> arguments to the function and then it'd do what it's supposed to: |
15 |
|
16 |
MULTILIB_WRAPPED_HEADERS will go public, I think. It's kind of nice to |
17 |
have a single way to list them. |
18 |
|
19 |
> wrap |
20 |
> headers from its arguments into a multilib-safe header, move the unsafe |
21 |
> headers to "${ED}"/tmp/multilib-include ; if this function is called, |
22 |
> then multibuild_merge_root "${ED}"/tmp/multilib-include |
23 |
> "${ED}"/usr/include |
24 |
> _must_ be called at the end of src_install. |
25 |
|
26 |
That part is fragile. I'd rather keep both steps encapsulated into two |
27 |
functions. Especially that if we decide to support wrapping headers |
28 |
outside /usr/include, the latter part would have to change. |
29 |
|
30 |
-- |
31 |
Best regards, |
32 |
Michał Górny |