Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: gentoo-dev@l.g.o
Cc: James Le Cuirot <chewi@g.o>
Subject: Re: [gentoo-dev] [PATCH 3/4] user-info.eclass: Fix for when building in a rooted prefix (EROOT)
Date: Tue, 06 Dec 2022 23:57:46
Message-Id: CAJ0EP41pU1_yb4wtKWM9YO0XxfW-eEkz2R7ucTqWAXPHjUyZbQ@mail.gmail.com
In Reply to: [gentoo-dev] [PATCH 3/4] user-info.eclass: Fix for when building in a rooted prefix (EROOT) by James Le Cuirot
1 On Tue, Dec 6, 2022 at 5:24 PM James Le Cuirot <chewi@g.o> wrote:
2 >
3 > Users are largely irrelevant for prefix, but we still don't want the
4 > build to break.
5 >
6 > Signed-off-by: James Le Cuirot <chewi@g.o>
7 > ---
8 > eclass/user-info.eclass | 8 ++++----
9 > 1 file changed, 4 insertions(+), 4 deletions(-)
10 >
11 > diff --git a/eclass/user-info.eclass b/eclass/user-info.eclass
12 > index 5550e4f08eeb..1339e36634a8 100644
13 > --- a/eclass/user-info.eclass
14 > +++ b/eclass/user-info.eclass
15 > @@ -48,7 +48,7 @@ egetent() {
16 > fi
17 >
18 > # Handle different ROOT
19 > - [[ -n ${ROOT} ]] && opts+=( -R "${ROOT}" )
20 > + [[ -n ${ROOT} ]] && opts+=( -R "${EROOT}" )
21
22 Another case where the [[ -n ${ROOT} ]] should probably be changed to
23 [[ -n ${EROOT} ]] if you actually want this to be prefix-aware.