Gentoo Archives: gentoo-dev

From: Andrew Ammerlaan <andrewammerlaan@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 1/2] docs.eclass: allow multiple documentation builders
Date: Thu, 10 Nov 2022 13:16:40
Message-Id: 8bfad42b-080d-72f8-7fd9-0e6a0f56d56d@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 1/2] docs.eclass: allow multiple documentation builders by Anna
1 On 10/11/2022 12:38, Anna wrote:
2 > On 2022-11-10 12:29, Andrew Ammerlaan wrote:
3 >> diff --git a/eclass/docs.eclass b/eclass/docs.eclass
4 >> index 611485c227f..f7a82939a53 100644
5 >> --- a/eclass/docs.eclass
6 >> +++ b/eclass/docs.eclass
7 >> @@ -207,16 +207,15 @@ sphinx_deps() {
8 >> }
9 >>
10 >> # @FUNCTION: sphinx_compile
11 >> -# @INTERNAL
12 >> # @DESCRIPTION:
13 >> # Calls sphinx to build docs.
14 >> -#
15 >> -# If you overwrite python_compile_all do not call
16 >> -# this function, call docs_compile instead
17 >> sphinx_compile() {
18 >> debug-print-function ${FUNCNAME}
19 >> use doc || return
20 >>
21 >> + : ${DOCS_DIR:="${S}"}
22 >> + : ${DOCS_OUTDIR:="${S}/_build/html/sphinx"}
23 >> +
24 >
25 > Could it be local?
26
27 I guess, but to me that feels a bit weird and confusing because this
28 variable can also be set globally in the ebuild.