Gentoo Archives: gentoo-dev

From: Alex Xu <alex_y_xu@×××××.ca>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFC: Update to elisp-common.eclass
Date: Mon, 19 May 2014 11:18:14
Message-Id: 5379E86F.1030906@yahoo.ca
In Reply to: Re: [gentoo-dev] RFC: Update to elisp-common.eclass by Ulrich Mueller
1 On 19/05/14 07:17 AM, Ulrich Mueller wrote:
2 >>>>>> On Mon, 19 May 2014, Alex Xu wrote:
3 >
4 >> On 18/05/14 02:13 PM, Ulrich Mueller wrote:
5 >>> if [[ ${EBUILD_PHASE} = *rm && ! -e ${sitelisp}/site-gentoo.el ]]; then
6 >>> ewarn "Refusing to create site-gentoo.el in ${EBUILD_PHASE} phase."
7 >>> return 0
8 >>> fi
9 >>>
10 >>> + [[ -d ${sitelisp} ]] \
11 >>> + || die "elisp-site-regen: Directory ${sitelisp} does not exist"
12 >>> +
13 >>> + [[ -d ${T} ]] \
14 >>> + || die "elisp-site-regen: Temporary directory ${T} does not exist"
15 >>> +
16 >> !qefs
17 >
18 >> if ROOT, EPREFIX, or SITELISP has whitespace, this will throw a syntax
19 >> error.
20 >
21 > Where? In the snippet you quoted, I don't see where whitespace in
22 > ${sitelisp} could cause any problems.
23 >
24 > "Word splitting and filename expansion are not performed on the words
25 > between the `[[' and `]]'" -- GNU Bash Reference Manual
26 >
27 > Ulrich
28 >
29
30 /me ponders
31
32 hm...
33
34 never mind, I was mistaken.

Attachments

File name MIME type
signature.asc application/pgp-signature