public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download: 
* [gentoo-dev]  Re: [gentoo-commits] gentoo-x86 commit in app-office/abiword: abiword-2.4.6.ebuild
  @ 2009-12-19  1:24 99%   ` Ryan Hill
  0 siblings, 0 replies; 1+ results
From: Ryan Hill @ 2009-12-19  1:24 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

On Thu, 17 Dec 2009 12:30:30 +0100
Gilles Dartiguelongue <eva@gentoo.org> wrote:

> > diff -u -r1.15 -r1.16
> > --- abiword-2.4.6.ebuild	4 Jan 2009 22:51:26 -0000	1.15
> > +++ abiword-2.4.6.ebuild	17 Dec 2009 10:54:05 -0000	1.16
> [...]
> > @@ -65,12 +65,12 @@
> >  
> >  src_install() {
> >  	dodir /usr/{bin,lib}
> > -	make DESTDIR="${D}" icondir="/usr/share/pixmaps" install || die "install failed"
> > +	emake DESTDIR="${D}" icondir="/usr/share/pixmaps" install || die "install failed"
> 
> I see no bug report about checking this actually works and making the
> fix. Please warn people before using your QA hat for doing things like
> this.

You want a bug report every time someone changes make to emake?!

If emake doesn't work, comment it.  Otherwise this is the type of thing that
anyone touching an ebuild should and will fix.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
     [not found]     <E1NLDzh-0003RM-Qc@stork.gentoo.org>
2009-12-17 11:30     ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/abiword: abiword-2.4.6.ebuild Gilles Dartiguelongue
2009-12-19  1:24 99%   ` Ryan Hill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox