Gentoo Archives: gentoo-dev

From: Ryan Hill <dirtyepic@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/abiword: abiword-2.4.6.ebuild
Date: Sat, 19 Dec 2009 01:24:46
Message-Id: 20091218192425.537b136f@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/abiword: abiword-2.4.6.ebuild by Gilles Dartiguelongue
1 On Thu, 17 Dec 2009 12:30:30 +0100
2 Gilles Dartiguelongue <eva@g.o> wrote:
3
4 > > diff -u -r1.15 -r1.16
5 > > --- abiword-2.4.6.ebuild 4 Jan 2009 22:51:26 -0000 1.15
6 > > +++ abiword-2.4.6.ebuild 17 Dec 2009 10:54:05 -0000 1.16
7 > [...]
8 > > @@ -65,12 +65,12 @@
9 > >
10 > > src_install() {
11 > > dodir /usr/{bin,lib}
12 > > - make DESTDIR="${D}" icondir="/usr/share/pixmaps" install || die "install failed"
13 > > + emake DESTDIR="${D}" icondir="/usr/share/pixmaps" install || die "install failed"
14 >
15 > I see no bug report about checking this actually works and making the
16 > fix. Please warn people before using your QA hat for doing things like
17 > this.
18
19 You want a bug report every time someone changes make to emake?!
20
21 If emake doesn't work, comment it. Otherwise this is the type of thing that
22 anyone touching an ebuild should and will fix.

Attachments

File name MIME type
signature.asc application/pgp-signature