Re: [gentoo-dev] [RFC] office-ext.eclass

[Michał Górny]

On Mon, 29 Aug 2011 09:11:31 +0200
Tomáš Chvátal <scarabeus@g.o> wrote:

> # @ECLASS: openoffice.eclass

Ekhm.

Also I think, you should use 'openoffice' in the name anyway,
or 'libreoffice', or whatever suggesting the actual office packages
branch.

> # @ECLASS-VARIABLE: OOO_EXTENSIONS
> # @REQUIRED
> # @DEFAULT_UNSET

I don't think you're supposed to mix these two.

> openoffice-ext_get_implementation() {
> 	debug-print-function ${FUNCNAME} "$@"
> 	local implementations="libreoffice openoffice"

Be modern, use an array :D.

> 	die "Could not determine office implementation!"

That sounds weird.

> }

> openoffice-ext_src_install() {
> 	debug-print-function ${FUNCNAME} "$@"
> 	local i
>
> 	insinto
> $(openoffice-ext_get_implementation)/share/extension/install/ for i
> in ${OOO_EXTENSIONS}; do doins ${i}
> 	done

I think you should use local scope if you're intending to use 'insinto'.

-- 
Best regards,
Michał Górny