Gentoo Archives: gentoo-dev

From: Matt Turner <mattst88@g.o>
To: gentoo development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] RFC: Require full $P not just $PN on stable/keyword commit messages
Date: Fri, 01 Nov 2019 20:36:20
Message-Id: CAEdQ38GdaoZ7gh8n=qYGaCMyXe5BOL17LEwk4ggzzDZWmn2Hmg@mail.gmail.com
In Reply to: [gentoo-dev] RFC: Require full $P not just $PN on stable/keyword commit messages by Michael 'veremitz' Everitt
On Fri, Nov 1, 2019 at 12:59 PM Michael 'veremitz' Everitt
<gentoo@×××××××.xyz> wrote:
> > Hello, > > I've noticed a lot of stabilisation commit messages (and a few keywording > ones too) simply state the package atom and not the relevant > release/version. I find this a little meaningless, as unless this is the > first time the package has ever been either stabilised or keyworded, it is > reasonable to expect that there is/was some transition point for a package > from when it first entered the Gentoo Repository. > > Therefore, it would be much /more/ useful to have the package-version > tagged in the commit message, so that you could easily grep logs for when a > given version of a package was stabilised, and/or keyworded. Granted, this > is more of-use in a historical context compared to a present (future?!) > one, but I would argue that it conveys more meaning -with- the version than > without.
Yes, I agree we should do this. My commit messages look like: sys-apps/systemd-243-r2: ppc64 stable, bug 698766 net-misc/mosh-1.3.2: added ~alpha In the past people have argued that the version in the title is superfluous since you can get the same info from git (log|show) --stat but the same (misguided argument) can be used to justify something absurd like simply making the bug number the subject. Honestly, just put the dang version in the title.

Replies