Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Gentoo Dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] [PATCH] Support Makefiles that set variables to a non-static value
Date: Thu, 09 Sep 2021 17:42:43
Message-Id: CAJ0EP41u5t5SmjHdVRg0KjMctXo48dR0y4B7F5vMiWoUdthBfg@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH] Support Makefiles that set variables to a non-static value by "Robin H. Johnson"
1 On Thu, Sep 9, 2021 at 1:21 PM Robin H. Johnson <robbat2@g.o> wrote:
2 >
3 > On Wed, Sep 01, 2021 at 02:44:11PM -0400, Mike Pagano wrote:
4 > > Previously, the kernel Makefile had to define version variables
5 > > as static string literals to be read.
6 > > This change will allow varibles defined as non-static values
7 > > to be read.
8 > Hi,
9 >
10 > This change has broken infra systems where /usr/src/ is empty because
11 > they use a binary kernel. /proc/config.gz does exist on those systems for this
12 > use case.
13 >
14 > Specifically, any package that uses linux-info to issues warnings via the '~'
15 > syntax now fails because "getfilevar_noexec VERSION ..." returns empty string.
16 >
17 > * Determining the location of the kernel source code
18 > * Unable to find kernel sources at /usr/src/linux
19 > * Please make sure that /usr/src/linux points at your running kernel,
20 > * (or the kernel you wish to build against).
21 > * Alternatively, set the KERNEL_DIR environment variable to the kernel sources location
22 > * Unable to calculate Linux Kernel version for build, attempting to use running version
23 > * ERROR: app-emulation/docker-20.10.7::gentoo failed (setup phase):
24 > * Unable to determine any Linux Kernel version, please report a bug
25 > *
26 > * Call stack:
27 > * ebuild.sh, line 127: Called pkg_setup
28 > * docker-20.10.7.ebuild, line 110: Called kernel_is 'lt' '4' '5'
29 > * linux-info.eclass, line 405: Called linux-info_get_any_version
30 > * linux-info.eclass, line 678: Called die
31 > * The specific snippet of code:
32 > * die "Unable to determine any Linux Kernel version, please report a bug"
33 >
34 > I'd like to propose that we revert the original CVS change that supported the fallback to getfilevar_noexec:
35 > https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/eclass/linux-info.eclass?id=ab160a941f5f52c95b47129d3243c693b05401e5
36
37 I cannot reproduce this with /proc/config.gz present.
38
39 % sudo ebuild docker-20.10.8.ebuild clean setup
40 * docker-20.10.8.tar.gz BLAKE2B SHA512 size ;-) ...
41 [ ok ]
42 * Determining the location of the kernel source code
43 * Unable to find kernel sources at /usr/src/linux
44 * Please make sure that /usr/src/linux points at your running kernel,
45 * (or the kernel you wish to build against).
46 * Alternatively, set the KERNEL_DIR environment variable to the
47 kernel sources location
48 * Unable to calculate Linux Kernel version for build, attempting to
49 use running version
50 * Checking for suitable kernel configuration options...
51 * CONFIG_BRIDGE_NETFILTER: is not set when it should be.
52 * CONFIG_IP_NF_TARGET_MASQUERADE: is not set when it should be.
53 * CONFIG_NETFILTER_XT_MATCH_IPVS: is not set when it should be.
54 * CONFIG_IP_VS: is not set when it should be.
55 * CONFIG_IP_VS_PROTO_TCP: is not set when it should be.
56 * CONFIG_IP_VS_PROTO_UDP: is not set when it should be.
57 * CONFIG_IP_VS_NFCT: is not set when it should be.
58 * CONFIG_IP_VS_RR: is not set when it should be.
59 * CONFIG_OVERLAY_FS: is not set when it should be.
60 * Please check to make sure these options are set correctly.
61 * Failure to do so may cause unexpected problems.