Re: [gentoo-dev] Arch-specific patches

[Seemant Kulleen]

On Wed, 2003-12-10 at 17:49, Aron Griffis wrote:
> On a similar topic to the -fPIC question, I've realized today that
>
>     if use alpha; then
>         epatch ${FILESDIR}/${P}-alpha.patch || die "epatch failed"
>     fi
>
> is really the wrong thing (and I'm not talking about the die part, which
> I know is controversial).  I'm talking about the conditional application
> of the patch.
>
> I think this should really be:
>
>     # Patch for 64-bit but apply everywhere
>     epatch ${FILESDIR}/${P}-alpha.patch || die "epatch failed"
>
Hi Aron,

Here's my take on this (slightly off-topic).  The way Azarah designed
epatch to be used can be seen very specifically in the xfree tarballs. 
So, if we decide to implement a *STANDARD* gentoo naming scheme and
locations for all our patches then it would like:

xxx_arch_${P*}-description.patch

xxx = number -- determines order in which it is applied
${P*} can be either ${PN} if the patch applies well enough to all
versions, ${P} if specifically for one, or ${PF} if it's just for this
revision of the ebuild (though epatch doesn't know about that, so that's
thorny I guess).

However, I agree 384% with you about making patches that can be applied
across all architectures without harming or otherwise affecting the
non-this ones.

Ciao,
-- 
Seemant Kulleen
Developer and Project Co-ordinator,
Gentoo Linux					http://dev.gentoo.org/~seemant

Public Key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x3458780E
Key fingerprint = 23A9 7CB5 9BBB 4F8D 549B 6593 EDA2 65D8 3458 780E