Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Cc: flameeyes@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-libs/glibc/files/eblits: pkg_preinst.eblit
Date: Thu, 14 Oct 2010 00:13:09
Message-Id: AANLkTinbu3-e9vvjspEjoch06OsaKX-Ng6uYunxnM81e@mail.gmail.com
1 On Fri, Oct 8, 2010 at 11:33 AM, Diego Petteno (flameeyes)
2 <flameeyes@g.o> wrote:
3 > flameeyes    10/10/08 15:33:13
4 >
5 >  Modified:             pkg_preinst.eblit
6 >  Log:
7 >  QA: avoid using $D when testing the just-built loader, as it might cause trouble when it contains colon characters; the fix is trivial.
8
9 you'd think trivial fixes wouldnt contain bugs ...
10
11 > +               pushd "${D}"/$(get_libdir) 2>/dev/null
12 > +               ./ld-*.so --library-path . ${x} > /dev/null \
13 >                        || die "simple run test (${x}) failed"
14 > +               popd 2>/dev/null
15
16 yet another reason (strace also readily comes to mind) i keep asking
17 you to post fixes and/or notify maintainers (base-system/toolchain)
18 instead of just committing things. pushd/popd do not write to stderr.
19 so this change now echoes the dirs when people emerge it. plus, this
20 really should be outside of the loop.
21 -mike

Replies