Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: Mike Frysinger <vapier@g.o>
Cc: gentoo-dev@l.g.o, marineam@g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/xen: ChangeLog xen-3.1.1.ebuild
Date: Wed, 31 Oct 2007 04:51:29
Message-Id: 20071031044841.GH30328@supernova
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/xen: ChangeLog xen-3.1.1.ebuild by Mike Frysinger
1 On 00:31 Wed 31 Oct , Mike Frysinger wrote:
2 > On Monday 15 October 2007, Donnie Berkholz wrote:
3 > > On 18:33 Mon 15 Oct , Micheal Marineau (marineam) wrote:
4 > > > 1.1 app-emulation/xen/xen-3.1.1.ebuild
5 > > >
6 > > > file :
7 > > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/xen-3.1
8 > > >.1.ebuild?rev=1.1&view=markup plain:
9 > > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/xen-3.1
10 > > >.1.ebuild?rev=1.1&content-type=text/plain
11 > > >
12 > > > src_compile() {
13 > > > local myopt
14 > > > use debug && myopt="${myopt} debug=y"
15 > > > use pae && myopt="${myopt} pae=y"
16 > > >
17 > > > if use custom-cflags; then
18 > > > filter-flags -fPIE -fstack-protector
19 > > > else
20 > > > unset CFLAGS
21 > > > fi
22 > > >
23 > > > # Send raw LDFLAGS so that --as-needed works
24 > > > emake LDFLAGS="$(raw-ldflags)" -C xen ${myopt} || die "compile failed"
25 > > > }
26 > > >
27 > > > src_install() {
28 > > > local myopt
29 > > > use debug && myopt="${myopt} debug=y"
30 > > > use pae && myopt="${myopt} pae=y"
31 > >
32 > > The environment should be preserved across phases, so you shouldn't have
33 > > to repeat this stuff.
34 >
35 > "myopt" is declared "local"
36
37 Sure, but did you notice it's set to the exact thing in both phases?
38 Seems a bit pointless.
39
40 Thanks,
41 Donnie
42 --
43 gentoo-dev@g.o mailing list

Replies