Gentoo Archives: gentoo-dev

From: James Le Cuirot <chewi@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] cdrom.eclass: Append to PROPERTIES variable.
Date: Fri, 26 Jul 2019 22:27:52
Message-Id: 20190726232729.69ae7bd7@symphony.aura-online.co.uk
In Reply to: [gentoo-dev] [PATCH] cdrom.eclass: Append to PROPERTIES variable. by "Ulrich Müller"
1 On Sat, 27 Jul 2019 00:25:21 +0200
2 Ulrich Müller <ulm@g.o> wrote:
3
4 > It is not accumulated across eclasses.
5 >
6 > Signed-off-by: Ulrich Müller <ulm@g.o>
7 > ---
8 > eclass/cdrom.eclass | 6 +++---
9 > 1 file changed, 3 insertions(+), 3 deletions(-)
10 >
11 > diff --git a/eclass/cdrom.eclass b/eclass/cdrom.eclass
12 > index 7b0eb9c6c3b5..77b9d6ceb209 100644
13 > --- a/eclass/cdrom.eclass
14 > +++ b/eclass/cdrom.eclass
15 > @@ -1,4 +1,4 @@
16 > -# Copyright 1999-2017 Gentoo Foundation
17 > +# Copyright 1999-2019 Gentoo Authors
18 > # Distributed under the terms of the GNU General Public License v2
19 >
20 > # @ECLASS: cdrom.eclass
21 > @@ -28,9 +28,9 @@ inherit portability
22 > # conditionally based on USE="cdinstall".
23 > if [[ ${CDROM_OPTIONAL} == "yes" ]] ; then
24 > IUSE="cdinstall"
25 > - PROPERTIES="cdinstall? ( interactive )"
26 > + PROPERTIES+=" cdinstall? ( interactive )"
27 > else
28 > - PROPERTIES="interactive"
29 > + PROPERTIES+=" interactive"
30 > fi
31 >
32 > # @FUNCTION: cdrom_get_cds
33
34 Ack, although shouldn't this variable be made to do that? Or perhaps
35 that's a PMS change?
36
37 --
38 James Le Cuirot (chewi)
39 Gentoo Linux Developer

Replies