Re: [gentoo-dev] [PATCH] toolchain.eclass: Register the D tc_feature

[Sam James]

> On 9 Feb 2023, at 20:04, Arsen Arsenović <arsen@g.o> wrote:
>
> This behavior is relied on elsewhere, for setting BDEPENDs correctly.
>
> Signed-off-by: Arsen Arsenović <arsen@g.o>
> ---
> Hi there,
>
> I was trying to merge GDC, and noticed that the non-selfhost BDEPEND is
> missing for GCC 13.  Specifically, the following block was never
> enterred:
>
>  # TODO: Add a pkg_setup & pkg_pretend check for whether the active compiler
>  # supports D.
>  if tc_has_feature d && tc_version_is_at_least 12.0 ; then
>   # D in 12+ is self-hosting and needs D to bootstrap.
>   # TODO: package some binary we can use, like for Ada
>   # bug #840182
>   BDEPEND+=" d? ( || ( sys-devel/gcc[d(-)] <sys-devel/gcc-12[d(-)] ) )"
>  fi
>
> This change enables the correct dependency to be emitted.
>

Can you add a Fixes: for the original commit where I added the D hack?

> eclass/toolchain.eclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
> index 6d8901d21812..06c044fd1d38 100644
> --- a/eclass/toolchain.eclass
> +++ b/eclass/toolchain.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2022 Gentoo Authors
> +# Copyright 1999-2023 Gentoo Authors
> # Distributed under the terms of the GNU General Public License v2
>
> # @ECLASS: toolchain.eclass
> @@ -271,7 +271,7 @@ if [[ ${PN} != kgcc64 && ${PN} != gcc-* ]] ; then
> tc_version_is_at_least 8.0 &&
> IUSE+=" systemtap" TC_FEATURES+=( systemtap )
>
> - tc_version_is_at_least 9.0 && IUSE+=" d"
> + tc_version_is_at_least 9.0 && IUSE+=" d" TC_FEATURES+=( d )

Thanks. I thought I'd checked for TC_FEATURES being populated.

Please push once added Fixes:, cheers!

Best,
sam