1 |
On Wed, 15 Dec 2010 20:06:14 +0000 (UTC), Constanze Hausner (constanze) |
2 |
wrote: |
3 |
> constanze 10/12/15 20:06:14 |
4 |
> |
5 |
> Modified: ChangeLog |
6 |
> Added: shorewall6-lite-4.4.15.1.ebuild |
7 |
> Log: |
8 |
> Version bump as requested by bug #339034. Thanks to Zoltan Karcagi. |
9 |
> |
10 |
> (Portage version: 2.1.9.24/cvs/Linux x86_64) |
11 |
|
12 |
Hello Constanze, |
13 |
I know you are new and I know you just did a version bump (which is |
14 |
normally just a rename). But, I always look for ways to reduce the |
15 |
signal to noise ratio of the packages so that user can quickly get good |
16 |
info instead of wading through the garbage. So, the next time you touch |
17 |
the shorewall suite, you may want to look all the einfo calls... |
18 |
|
19 |
> src_compile() { |
20 |
> einfo "Nothing to compile." |
21 |
> } |
22 |
|
23 |
This could be rewritten as: |
24 |
|
25 |
src_compile() { :; } |
26 |
|
27 |
because why would anyone really care if there is nothing to compile?! |
28 |
|
29 |
> pkg_postinst() { |
30 |
> einfo |
31 |
> einfo "Documentation is available at http://www.shorewall.net" |
32 |
> einfo "There are man pages for ${PN}(8) and for each" |
33 |
> einfo "configuration file." |
34 |
|
35 |
ya, there are man pages for most every app...no need to explictly state |
36 |
that. |
37 |
|
38 |
> einfo |
39 |
> einfo "You should have already generated a firewall script with" |
40 |
> einfo "'shorewall compile' on the administrative Shorewall6." |
41 |
> einfo "Please refer to" |
42 |
> einfo "http://www.shorewall.net/CompiledPrograms.html" |
43 |
> einfo |
44 |
> einfo "Known problems:" |
45 |
> einfo |
46 |
> |
47 |
> "http://shorewall.net/pub/${MY_PN}/${MY_PV_TREE}/${MY_P}/known_problems.txt" |
48 |
> } |
49 |
|
50 |
In general, I think einfo is pretty worthless because of the default |
51 |
PORTAGE_ELOG_CLASSES="log warn error" value. |
52 |
|
53 |
A challenge to everyone (myself included): Remove useless messages in |
54 |
your ebuilds. |
55 |
|
56 |
-Jeremy |