Gentoo Archives: gentoo-dev

From: Gilles Dartiguelongue <eva@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update
Date: Sun, 01 Sep 2013 11:42:11
Message-Id: 1378034967.19411.16.camel@kanae
In Reply to: Re: [gentoo-dev] [PATCH] gnome2-utils.eclass add support for gdk-pixbuf cache update by Gilles Dartiguelongue
1 Le samedi 31 août 2013 à 18:44 +0200, Gilles Dartiguelongue a écrit :
2 > Le samedi 31 août 2013 à 16:49 +0200, Michał Górny a écrit :
3 > > Dnia 2013-08-31, o godz. 15:00:43
4 > > Gilles Dartiguelongue <eva@g.o> napisał(a):
5 > >
6 > > > Le samedi 31 août 2013 à 13:40 +0200, Michał Górny a écrit :
7 > > > > > + cat "${tmp_file}" > "${EROOT}usr/$(get_libdir)/gdk-pixbuf-2.0/2.10.0/loaders.cache"
8 > > > >
9 > > > > Why not mv or cp? Also you need '|| die' here since 'cat' can fail
10 > > > > writing.
11
12 Thanks for pacho's bugzillafu, we've got the original reports here:
13
14 https://bugs.gentoo.org/show_bug.cgi?id=413529
15 https://bugs.gentoo.org/show_bug.cgi?id=413485
16
17 It seems the cat usage was only to avoid handling file permission
18 issues.
19
20 The use of a temporary file itself it to avoid having a corrupted file
21 if the command fails.
22
23 As for immodules I plan to provide patches to fix it after we agree on
24 this one.
25
26 --
27 Gilles Dartiguelongue <eva@g.o>
28 Gentoo
29
30 --
31 Gilles Dartiguelongue <eva@g.o>
32 Gentoo

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies