1 |
On Thu, 22 Sep 2011 10:58:28 +0000 |
2 |
"Jorge Manuel B. S. Vicetto" <jmbsvicetto@g.o> wrote: |
3 |
|
4 |
> On 22-09-2011 08:11, Michał Górny wrote: |
5 |
> > On Thu, 22 Sep 2011 09:01:17 +0200 Ulrich Mueller <ulm@g.o> |
6 |
> > wrote: |
7 |
> > |
8 |
> >>> Attaching fixed version of the last two patches, and a |
9 |
> >>> complete eclass for convenience. |
10 |
> >> |
11 |
> >> Just a general comment: Is it really necessary to change all [[ |
12 |
> >> -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more |
13 |
> >> obscure [[ ${foo} ]] and [[ ! ${foo} ]]? |
14 |
> >> |
15 |
> >> The shortest possible form is not always the one that's best |
16 |
> >> readable. |
17 |
> > |
18 |
> > The style change was approved by Donnie already. |
19 |
> |
20 |
> You mean that Donnie agreed with the style change. It's not up to any |
21 |
> individual developer to "approve" such a change for the entire tree. |
22 |
|
23 |
What kind of 'entire tree'? It is just a single eclass, and its |
24 |
maintainer approves coding style change. Where do you see a problem |
25 |
with that? |
26 |
|
27 |
-- |
28 |
Best regards, |
29 |
Michał Górny |